- Issue created by @ravi kant
- Issue was unassigned.
- Status changed to Needs review
9 months ago 8:44am 23 April 2024 - 🇮🇳India ravi kant Jaipur
Created MR!34 social media icons display dynamic work.
Hi @ravi kant,
I've reviewed the MR!34 and I found you have addressed the drupal_get_path() not found issue also but that is resolved in an issue already refer https://www.drupal.org/project/school_theme/issues/3437946 🐛 drupal_get_path() is deprecated in Drupal 9.3.0 and removed from Drupal 10.0.0 RTBC . Since this issue is not a part of this issue we can ignore these changes. Apart from that the linkedin and youtube icons are not visible. Also if the checkbox to show all the social icons is selected but the social icons url is not set then the footer remains blank only with the title, for this scenario we could set the default values for the social icons url or we could use the address of the current page by making use of the '#' in href. Lastly since the footer social icon visibility is already been addressed in the issue - https://www.drupal.org/project/school_theme/issues/3442741 🐛 Linkedin and YouTube icons are not visible in footer Needs work . I think it is better to resolve the remaining footer icon related issue in related issue issue itself. I've included the related issue link.