- Issue created by @quietone
- Status changed to Active
8 months ago 12:56pm 22 April 2024 - First commit to issue fork.
- Merge request !7656Issue #3442532: Removed deprecated code in views module โ (Closed) created by smustgrave
- Status changed to Needs review
8 months ago 8:50pm 22 April 2024 - Status changed to Needs work
8 months ago 9:34pm 22 April 2024 - ๐ฎ๐ณIndia pradhumanjainOSL
pradhumanjain2311 โ made their first commit to this issueโs fork.
- First commit to issue fork.
- Status changed to Needs review
8 months ago 2:24pm 23 April 2024 - ๐ซ๐ทFrance andypost
Clean-up what was able to find, added views_ui
btw there's
views.view.*.mapping.display.sequence.mapping.cache_metadata.mapping.cacheable
which has comment as it was deprecated but all views has this property, I bet it needs follow-up somehow - ๐บ๐ธUnited States smustgrave
I tried removing that before and got schema errors everywhere.
- ๐บ๐ธUnited States smustgrave
@andypost can you take a look at the phpcs.
- ๐ซ๐ทFrance andypost
Thank you! fixed CS, re #10 - that's why it needs follow-up
- ๐ฌ๐งUnited Kingdom catch
#9/10 what's happened is that issues have been committed that update the views schema, with an update path, but which don't fix the shipped views to be compliant. Then when we remove bc layers like there, everything blows up. This is a problem with the original MRs that went in, but in most cases that was months/years ago.
The ideal thing is to either manually fix or re-export those views so that they have the correct schema, but we could also open a separate issue for anything tricky here and just commit the changes that don't require updating test fixtures.
I ran into similar problems on ๐ Remove redudundat hook_ENTITY_TYPE_presave() and ViewsConfigUpdater methods Active
- ๐บ๐ธUnited States smustgrave
Opened ๐ Update core views with correct config Active
- Status changed to RTBC
8 months ago 3:14pm 23 April 2024 - Status changed to Fixed
8 months ago 3:39pm 23 April 2024 Automatically closed - issue fixed for 2 weeks with no activity.