"Exclude textfield" from auto-submit logic ignored since 6.0.4 when using autocomplete

Would try out 6.0.5 as there a fatal bug in 6.0.4 that messed with the view configuration

Thanks smustgrave but getting the same problem in both 6.0.4 and 6.0.5 as mentioned in the original post.

I can confirm the same problem: For 6.0.4 and 6.0.5, excluding the text field from auto submit does not work.

The db update when upgrading from 6.0.3 to 6.0.4 also changed the existing BEF configuration in the view where it was used, incl. disabling the autosubmit and removing the default text for the text field - rather then just adding the config for collapsing, which I assume it was supposed to do.

See this config change as an example:

          bef:
-            general:
-              autosubmit: true
-              autosubmit_exclude_textfield: true
-              autosubmit_hide: true
-              input_required: false
-              allow_secondary: false
-              secondary_label: 'Advanced options'
-              text_input_required: 'Select any filter and click on Apply to see results'
-              text_input_required_format: basic_html
-            sort:
-              plugin_id: default
-              advanced:
-                combine: false
-                combine_rewrite: ''
-                reset: false
-                reset_label: ''
-                collapsible: false
-                collapsible_label: 'Sort options'
-                is_secondary: false
             filter:
-              search_api_fulltext:
-                plugin_id: default
+              filter:
                 advanced:
-                  sort_options: false
-                  placeholder_text: 'Search in the text'
-                  rewrite:
-                    filter_rewrite_values: ''
-                  collapsible: false
-                  is_secondary: false
+                  collapsible_disable_automatic_open: false
       access:
         type: none

This seems to be the cause of the issue: https://git.drupalcode.org/project/better_exposed_filters/-/commit/7fbd2...

Without the reference, the attribute to exclude it from autosubmit is not set in the form anymore.

But I'm not sure why this change was introduced and if simply reverting would cause other problems.

As moritzkunz saw, reverting that change does fix this issue. Additionally, the change made in that diff appears to be equivalent to removing that code block as modifying the variable passed by reference is the only thing it does.

Reverting it doesn't appear to change the behavior around expanded/collapsed facets mentioned in the referenced issue, though it's "broken" in the same way as described there with or without this patch ( https://www.drupal.org/project/better_exposed_filters/issues/3266858 ✨ Allow not automatically opening collapsed filter Needs review ).

Appears to be the related issue

Tests were there just wasn't pulling a fresh copy of Html to review

Since this is a regression and trying to plan a release today or tomorrow going to merge. can always reopen

Thanks, that works for me, so I would RTBC it, if it hadn't been already set to Fixed.

Automatically closed - issue fixed for 2 weeks with no activity.

Could we have a release with this? pretty please

Will try and plan one early next week. Waiting to see if anyone reviews the jquery removal tickets.

Was this actually merged? I don't see it in the 6.0.x/7.0.x branches...

Here's the commit in the 6.0.x branch - this seems to be included in release 6.0.6, although the commit message doesn't mention this issue.