Allow not automatically opening collapsed filter

Tested out the MR but still closed by default.

Thanks for trying it out. Staying closed is the intention though.

Without the patch it opens if there is a selected option inside.

With the patch and ticking 'Disable the automatic opening of collapsed filters with selections', it is expected to now stay closed (necessary when the UX practice of 'Applied Filters (aka Active Filters)' is in place described further in the issue summary.

Gotcha. Could we get a small test for this feature added if you have time?

smustgrave → credited tim-diels → .

Closed ✨ Allow secondary options to be closed by default after search Closed: duplicate as duplicate

smustgrave → changed the visibility of the branch 8.x-5.x to hidden.

Sorry for the noise.

I ended up adding a test for another issue that seemed aligned with this so I just went ahead and extended the test for here

Hate to do it but this caused 🐛 Update hook wiped out config Active and had to revert. Safer to revert then spend a few days with this in the wild.

smustgrave → credited lelkneralfaro → .

For reporting this issue.

scott_euser → changed the visibility of the branch 3266858-collapsed-not-auto-open to hidden.

scott_euser → changed the visibility of the branch 6.0.x to hidden.

I'm not sure how that upgrade hook ever worked, sorry about that! Sure enough, a quick test and it wipes for me too. Perhaps way back then in 2022 the format was slightly different... Glad you caught it quickly! Updated the update hook + added a test to show its working now (before updating the update hook, test fails with wiped config as expected).

smustgrave mentioned that 'Version: 6.0.x-dev" would solve this issue 🐛 Reset Button Closes Entity Browser View Instead of Reseting Form Active , but it doesn't. Tested on Simple Test Me.

Yep it got rolled back (see comment #14). Thanks for testing it out, what were the results? Did it solve the problem for you as well?

Could we have a diff of both upgrade functions? Hard to spot what was wrong, and how this is fixed now.

Sure, diff is here. The original update hook started with an empty $bef_settings and built it up (and obviously not fully). This update hook starts from the existing config and only modifies the bit it needs to if it finds it.

The original update hook essentially copy pasted from better_exposed_filters_update_8001() and modified which resulted in #3112834: Exposed Filter Settings gone after upgrade → .

As discussed in 🐛 "Exclude textfield" from auto-submit logic ignored since 6.0.4 when using autocomplete Active the change here (https://git.drupalcode.org/project/better_exposed_filters/-/commit/7fbd2...) breaks the ability to disable auto-submit on text fields. The change effectively removes the application of the "data-bef-auto-submit-exclude" attribute.

I'm not sure why this change was made in the first place, perhaps it was due to that attribute causing something to happen on the js side of things? In any case, I doubt that removing this functionality was an intended change.

I've added a patch in #3442511-6: "Exclude textfield" from auto-submit logic ignored since 6.0.4 when using autocomplete → reverting that change.

@seanpb did you mean to post that in this thread? If so, could you explain how it is related to this merge request?

@scott_euser, yes, MR 20 (and 61) caused not only the config-breaking issue but also the one in 🐛 "Exclude textfield" from auto-submit logic ignored since 6.0.4 when using autocomplete Active . The specific commit that appears to cause the issue is the one linked in my comment above (#25).

Will post in the other issue but believe these are unrelated since this is just now being committed.

smustgrave → closed merge request !70

Automatically closed - issue fixed for 2 weeks with no activity.