πŸ‡©πŸ‡ͺGermany @seanpb

Account created on 12 November 2015, over 8 years ago
#

Recent comments

πŸ‡©πŸ‡ͺGermany seanpb

@scott_euser, yes, MR 20 (and 61) caused not only the config-breaking issue but also the one in πŸ› "Exclude textfield" from auto-submit logic ignored since 6.0.4 when using autocomplete Active . The specific commit that appears to cause the issue is the one linked in my comment above (#25).

πŸ‡©πŸ‡ͺGermany seanpb

As discussed in πŸ› "Exclude textfield" from auto-submit logic ignored since 6.0.4 when using autocomplete Active the change here (https://git.drupalcode.org/project/better_exposed_filters/-/commit/7fbd2...) breaks the ability to disable auto-submit on text fields. The change effectively removes the application of the "data-bef-auto-submit-exclude" attribute.

I'm not sure why this change was made in the first place, perhaps it was due to that attribute causing something to happen on the js side of things? In any case, I doubt that removing this functionality was an intended change.

I've added a patch in #3442511-6: "Exclude textfield" from auto-submit logic ignored since 6.0.4 when using autocomplete β†’ reverting that change.

πŸ‡©πŸ‡ͺGermany seanpb

As moritzkunz saw, reverting that change does fix this issue. Additionally, the change made in that diff appears to be equivalent to removing that code block as modifying the variable passed by reference is the only thing it does.

Reverting it doesn't appear to change the behavior around expanded/collapsed facets mentioned in the referenced issue, though it's "broken" in the same way as described there with or without this patch ( https://www.drupal.org/project/better_exposed_filters/issues/3266858 ✨ Allow not automatically opening collapsed filter Needs review ).

Production build 0.69.0 2024