JS error caused by toolbar library when toolbar is not present

These changes (on that branch) fix the issue: https://git.drupalcode.org/issue/navigation_extra_tools-3515628/-/commit...

Thank you for submitting the fix. However, you don't appear to have opened a merge request. I'd be grateful if you could open one.

What is the reasoning behind removing the autowire form the legacy hooks? I was under the impression autowiring was needed for backwards compatibility of legacy hooks.

@seanpb Thanks for reporting this, and providing the fix. However, it still needs a merge request.

Is there a way we could add a test to check for the JS error to ensure I don't unwittingly break it again?

I forgot to set back to needs work in my previous comment.

I think we can use autowiring for the service.

I've tested loading the front page when not logged in, and confirmed none of the navigation libraries appear in the source. When I test under 1.1.x branch, I see a number of navigation libraries.

I'll look into adding a test for this, but will merge soon as it affects the page loading for anonymous users.

I have added a test that checks for the presence of Navigation JS files for the admin user, and verifies that they are not present when logged out. This fails when run against the 1.1 branch, and is successful with this change.

Moving to needs review.

I would have liked to have a review, but as this is affecting site performance, I would like to get the fix into a release, I'll have to rely on the test coverage. Moving to RTBC.

Thank you for reporting and submitting the fix, @seanpb. The test coverage explicitly covers this now, so hopefully it won't cause further issues.

Automatically closed - issue fixed for 2 weeks with no activity.