- Issue created by @ckrina
- Status changed to Needs review
8 months ago 8:20pm 1 April 2024 - ๐ท๐ธSerbia finnsky
The main problem we have now is that some things in the scripts were done for a completely different menu and other scenarios.
I've added controlled hover open.
On hover we wait for 500ms and then check if button not opened by click yet, or button still hovered.
Looks much smoother than before.
Also in this MR i've commented few things which should be reworked or at least discussed.
1. Imo we don't need to close all popovers on any tooltip open. This is current behaviour https://gyazo.com/b8eff73a5e9ea7cbdba0047f8ce953cc and i'm fine with it
2. ScrollIntoView on active url in popover. It looks weird now, probably we only need to activate this ONLY when active url is far outside from scroll area.
I think we can move that ^ 2 things into separated issues/discussions.
3. Added fix for this. We have 2 levels on menu. So we need to avoid cases when open child menu closes parent.
https://www.drupal.org/project/navigation/issues/3437375 ๐ There should be only one submenu expanded in the drawer at a time ActivePlease review.
SB: https://sparkling-gaufre-c402f2.netlify.app/iframe.html?args=&id=page--b...
- ๐ฎ๐ณIndia Kanchan Bhogade
Hi,
I've tried to reproduce the mentioned issue on Drupal 11.x with Standard and Umami; but unable to reproduce the issue, Drover does not close when moving for submenus. Please let me know if I'm missing anythingadding recording for the reference
- ๐ช๐ธSpain ckrina Barcelona
ckrina โ changed the visibility of the branch 3437401-drawer-closes-when to hidden.
- ๐ท๐ธSerbia finnsky
@Kanchan Bhogade thank you for review! Could you please retest in current 1.x
In your video i see pretty outdated things. - Status changed to Needs work
8 months ago 7:45am 2 April 2024 - ๐ช๐ธSpain ckrina Barcelona
This is actually implementing the strategy of a delay, which is what I mentioned to try to avoid :)
Implement a solution that doesn't add extra reaction time but that improves the current interaction.
If you want to go initially for beta this week with the delay it's OK because we're making it look smoother, but let's open another issue for that (plus the other JS polishing that you might want to do). The final solution though should follow the strategy that "predicts the mouse movement".
That's why I pasted links to libraries and strategies that have found a solution already without implementing a delay:
- Status changed to Needs review
8 months ago 4:25pm 2 April 2024 - ๐ท๐ธSerbia finnsky
Pushed with green debug path displays that safe polygons.
- ๐ท๐ธSerbia finnsky
Removed green lines and fixed end point
https://sparkling-gaufre-c402f2.netlify.app/iframe.html?args=&id=page--b... for debug info
- Status changed to Fixed
8 months ago 10:55am 3 April 2024 - ๐ช๐ธSpain ckrina Barcelona
Merging this! Let's follow-up with the small things found and discussed in Slack this past days in other issues so this improvement can unblock the beta release Thanks for all the great and fast work here, @finnsky!!
-
ckrina โ
committed a140fe51 on 1.x authored by
finnsky โ
Js polishing. - #3437401
-
ckrina โ
committed a140fe51 on 1.x authored by
finnsky โ
-
lauriii โ
committed 5f1a3607 on 1.x
Follow-up to #3437401: Rename CSS variable in toolbar-popover.js
-
lauriii โ
committed 5f1a3607 on 1.x
Automatically closed - issue fixed for 2 weeks with no activity.