Automated Drupal 11 compatibility fixes for theme_switcher

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

These packages were used to generate the fixes:

1. drupal/upgrade_status: 4.1.0
2. mglaman/phpstan-drupal: 1.2.9
3. palantirnet/drupal-rector: 0.20.1

I was evaluating the module and noticed the Automated Tests was setup, but no tests were added, so I created a new branch in the issue fork to add a simple test to switchover to Gitlab CI, which needs to be done soon. Hopefully it works.

Test passes now on both Drupal 10 and Drupal 11.

D11 is out!

I'm not able to install MR!8 for some reason -- composer can't seem to find the 3434980-gitlabci-dev branch in the fork.

I was able to clone the fork and branch successfully on a new DrupalPod instance.

gitpod /workspace/drupalpod/repos/theme_switcher (3434980-gitlabci) $ git status
On branch 3434980-gitlabci
Your branch is up to date with 'theme_switcher-3434980/3434980-gitlabci'.

nothing to commit, working tree clean
gitpod /workspace/drupalpod/repos/theme_switcher (3434980-gitlabci) $ git remote -vvv
origin  https://git.drupalcode.org/project/theme_switcher.git (fetch)
origin  https://git.drupalcode.org/project/theme_switcher.git (push)
theme_switcher-3434980  https://git.drupalcode.org/issue/theme_switcher-3434980.git (fetch)
theme_switcher-3434980  https://git.drupalcode.org/issue/theme_switcher-3434980.git (push)

I'll merge origin/2.x and push to the fork. Hopefully that helps.

No luck, mradcliffe... with my composer.json repositories set up like so

        {
            "type": "vcs",
            "url": "https://git.drupalcode.org/issue/theme_switcher-3434980.git"
        },
        {
            "type": "composer",
            "url": "https://packages.drupal.org/8"
        }

I get

$ composer require drupal/theme_switcher:3434980-gitlabci-dev
Your requirements could not be resolved to an installable set of packages.
Problem 1
- Root composer.json requires drupal/theme_switcher 3434980-gitlabci-dev, found drupal/theme_switcher[dev-8.x-1.x] but it does not match the constraint.

Oh, you're trying to download the module from the fork? This is a composer issue rather than a git issue. The branch and issue fork exist in git.

But it would be easier to test the issue fork in DrupalPod there is a browser extension for DrupalPod that makes this seamless on an issue page.

When I'm working locally with my own modules, I have the module checked out directly and can add git remotes and checkout branches from issue forks.

I was able to clone in local. Verified functionality in Drupal 10 and Drupal 11 which looks good to me.
Upgrade status and PHPCS is also showing no error found.

Changing status to RTBC.

theme_switcher-3434980 % git status
On branch 3434980-gitlabci
Your branch is up to date with 'origin/3434980-gitlabci'.

nothing to commit, working tree clean
theme_switcher-3434980 %

liam morland → made their first commit to this issue’s fork.

I made some simple coding standards fixes and now tests are fully passing.

I wasn't sure if fixing phpcs wold be in scope, but it's great to see fully green. Thank you, @liam morland.

Perhaps the testing-related stuff should be moved to 📌 Write basic tests Active .

Thank you! Merged !8 without sqashing commits!

anybody → closed merge request !7

Just tagged D11 compatible 2.1.0 release, thank you all! 🎉

Automatically closed - issue fixed for 2 weeks with no activity.