- Issue created by @Project Update Bot
- last update
3 months ago 15 pass This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module β , even with these changes, this module is not yet compatible with Drupal 11.
Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.
Therefore these changes did not update the
info.yml
file for Drupal 11 compatibility.Leaving this issue open, even after committing the current patch, will allow the Project Update Bot β to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug info
Bot run #11-121090This patch was created using these packages:
- drupal/upgrade_status: 4.1.0
- mglaman/phpstan-drupal: 1.2.7
- palantirnet/drupal-rector: 0.20.1
- last update
3 months ago 15 pass - last update
2 months ago 15 pass This comment was forced and has ignored the check if a change was already posted. This is only done when we want to update the issue without waiting for changes to happen.
This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module β , even with these changes, this module is not yet compatible with Drupal 11.
Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.
Therefore, these changes did not update the
info.yml
file for Drupal 11 compatibility.The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.
Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot β to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug information
Bot run #11-137198These packages were used to generate the fixes:
- drupal/upgrade_status: 4.1.0
- mglaman/phpstan-drupal: 1.2.10
- palantirnet/drupal-rector: 0.20.1
- last update
2 months ago 15 pass - First commit to issue fork.
- last update
27 days ago 15 pass - π―π΅Japan ptmkenny
Added an MR with initial support for Drupal 11. Once π Add GitLab CI template Needs review gets added this will be easier to test.
- π―π΅Japan ptmkenny
Upgrade Status now shows only a single Drupal 12 deprecation, which is marked ignore for now:
web/modules/json_field/src/Element/JsonText.php: +--------+------+---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+ | status | line | message | +--------+------+---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+ | Ignore | 14 | Class Drupal\json_field\Element\JsonText extends deprecated class Drupal\Core\Render\Element\RenderElement. Deprecated in drupal:10.3.0 and is removed from drupal:12.0.0. Use Drupal\Core\Render\Element\RenderElementBase instead. | +--------+------+---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
So I think this is ready for consideration.
- Status changed to Postponed
25 days ago 7:52am 22 May 2024 - π§πͺBelgium Wim Leers Ghent π§πͺπͺπΊ
Let's first get π Add GitLab CI template Needs review in, so that we can observe the tests passing on Drupal 11 and require tests to pass on "the next major"? π
- π¨π¦Canada tbradbury
travis-bradbury β made their first commit to this issueβs fork.
- last update
25 days ago 15 pass - π¨π¦Canada tbradbury
I added a change to make field type categories compatible with Drupal 11: https://git.drupalcode.org/project/json_field/-/merge_requests/22/diffs?...
See the change record: https://www.drupal.org/node/3375748 β .
This doesn't change the issue status since CI should still come first.
- last update
20 days ago Build Successful - Status changed to Needs review
20 days ago 11:26am 27 May 2024 - π―π΅Japan ptmkenny
CI is in so I merged in the latest changes and am opening this back up.
- last update
20 days ago 15 pass - Status changed to Needs work
20 days ago 11:38am 27 May 2024 - π―π΅Japan ptmkenny
Hmm, composer install won't run on GitLab CI because Feeds doesn't yet have a dev branch that supports Drupal 11. As a temporary measure, I'm going to remove feeds as a dependency, which should allow the test to run, but we should add this back before the final release (because it will introduce phpstan failures).
- last update
20 days ago 15 pass - Status changed to Needs review
17 days ago 4:00pm 30 May 2024 - last update
17 days ago 15 pass This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module β , even with these changes, this module is not yet compatible with Drupal 11.
Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.
Therefore, these changes did not update the
info.yml
file for Drupal 11 compatibility.The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.
Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot β to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug information
Bot run #11-185727These packages were used to generate the fixes:
- drupal/upgrade_status: 4.3.1
- mglaman/phpstan-drupal: 1.2.11
- palantirnet/drupal-rector: 0.20.1
- Merge request !32Draft: Automated Project Update Bot fixes β (Closed) created by Project Update Bot
- Open on Drupal.org βCore: 9.5.x + Environment: PHP 8.0 & MySQL 5.7last update
17 days ago Not currently mergeable. - last update
9 days ago 17 pass - πΊπΈUnited States DamienMcKenna NH, USA
DamienMcKenna β changed the visibility of the branch project-update-bot-only to hidden.
- last update
9 days ago 17 pass - last update
9 days ago 17 pass - last update
9 days ago 17 pass - πΊπΈUnited States DamienMcKenna NH, USA
This change breaks on PHP 7.4:
diff --git a/src/Normalizer/JsonItemNormalizer.php b/src/Normalizer/JsonItemNormalizer.php index 8739196..40e82b1 100644 --- a/src/Normalizer/JsonItemNormalizer.php +++ b/src/Normalizer/JsonItemNormalizer.php @@ -21,7 +21,7 @@ class JsonItemNormalizer extends NormalizerBase { /** * {@inheritdoc} */ + public function normalize($object, $format = NULL, array $context = []) { - public function normalize($object, $format = NULL, array $context = []): array|bool|string|int|float|null|\ArrayObject { $field = $object->getParent(); return [ $field->getName() => [$object->getValue()],
We'll need to specify the module requires PHP 8 if we go with this. It also means we can't use gitlab to run the tests against the last major release (D9) because it runs PHP 7.4.
Choices..
- last update
9 days ago 17 pass - πΊπΈUnited States DamienMcKenna NH, USA
The tests fail on D11 because of the change, so we need drop support for PHP 7.
- last update
9 days ago 17 pass - last update
9 days ago 5 pass, 4 fail - last update
9 days ago 5 pass, 4 fail - last update
9 days ago 5 pass, 4 fail - last update
9 days ago 5 pass, 4 fail - πΊπΈUnited States DamienMcKenna NH, USA
Some of the Composer-related failures come from the Feeds dependency, see π Automated Drupal 11 compatibility fixes for feeds Needs work for details.
- πΊπΈUnited States DamienMcKenna NH, USA
I think we might have to commit the changes but disable next major and prev major because of Composer and phpstan problems.
- last update
9 days ago 5 pass, 4 fail - last update
9 days ago 5 pass, 4 fail - last update
9 days ago 5 pass, 4 fail - last update
9 days ago 5 pass, 4 fail - Status changed to RTBC
9 days ago 5:21pm 7 June 2024 - πΊπΈUnited States DamienMcKenna NH, USA
So.. I think this could be committed now and the other issues looked into separately.
- π―π΅Japan ptmkenny
If you wanted to run the tests on Drupal 9 but only with PHP 8, I'm almost certain there is a way to configure GitLab CI to do that, but I don't know how off the top of my head. If that's something that would be desirable, I can look into it.
- πΊπΈUnited States DamienMcKenna NH, USA
Yes please, I think that would be a great addition. Thank you.
- πΊπΈUnited States DamienMcKenna NH, USA
Oh wait. Never mind - the API change for D11 breaks D9. So I guess the next release needs to completely drop Drupal 9 support. Which means we can revert the PHP 8 requirement and just require D10.
- last update
9 days ago Composer require failure -
DamienMcKenna β
committed de7b2b88 on 8.x-1.x authored by
ptmkenny β
Issue #3431154 by DamienMcKenna, Project Update Bot, ptmkenny, travis-...
-
DamienMcKenna β
committed de7b2b88 on 8.x-1.x authored by
ptmkenny β
- Status changed to Fixed
6 days ago 2:18pm 10 June 2024 - πΊπΈUnited States DamienMcKenna NH, USA
I opened a separate issue to deal with re-enabling the D11 tests: π Enable Drupal 11 tests once Feeds is fixed Active
Committed. Thanks everyone.