🇨🇦Canada @travis-bradbury

Yeah, the release notes are probably the best place for that.

travis-bradbury → created an issue.

travis-bradbury → created an issue.

Right now, cases are required to contain a lower-case letter. That breaks on cases with a letter and number.

enum FiscalQuarter {
  case Q1;
  case Q2;
  case Q3;
  case Q4;
}

Those are UpperCamel. The sniff could look for multiple upper case characters in a row, but that would break two other cases that are allowed now:

  // Upper case parts are allowed for now.
  case FourJSONCase = 4;
  case FiveAndAHorseCorrect = 5;

"AHorse" is UpperCamel, and sequential uppercase like "JSON" are allowed.

I haven't had a reason to continue development. If you're looking to do something with it, #2944570: Provide cost fields as traits → needs to be finished, and #3070667: Test order item costs → .

I added a change to make field type categories compatible with Drupal 11: https://git.drupalcode.org/project/json_field/-/merge_requests/22/diffs?...

See the change record: https://www.drupal.org/node/3375748 → .

This doesn't change the issue status since CI should still come first.

travis-bradbury → made their first commit to this issue’s fork.

I think this is a duplicate of #2822359: Support "entity" property definition in entity queries using Entity Reference Revisions fields → .

#5 doesn't actually work in my use case. It works in the test because there's no translations. The test should include that.

Here's one that checks for the same revision ID if the langcode is the same (so it isn't true just because there is some translation, and it IS true if the revision for any translation has changed).

The test in this one does use translation, so it catches the problem with #5.

Oops, #2 forgot to add a use statement.

Here's a test that shows the error.

tbradbury → created an issue.

#3 had issues with translations. This patch addresses that by only comparing revision IDs if there isn't a translation.

#2's test-only patch is still valid so I'm not uploading another one of those.

tbradbury → created an issue.