- Issue created by @tbradbury
- Status changed to Needs review
over 1 year ago 6:28pm 1 February 2023 The last submitted patch, 2: 3338387-2.patch, failed testing. View results β
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- π¨π¦Canada tbradbury
#3 had issues with translations. This patch addresses that by only comparing revision IDs if there isn't a translation.
#2's test-only patch is still valid so I'm not uploading another one of those.
- π¨π¦Canada tbradbury
#5 doesn't actually work in my use case. It works in the test because there's no translations. The test should include that.
Here's one that checks for the same revision ID if the langcode is the same (so it isn't true just because there is some translation, and it IS true if the revision for any translation has changed).
The test in this one does use translation, so it catches the problem with #5.
The last submitted patch, 7: 3338387-7-test-only.patch, failed testing. View results β
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.The last submitted patch, 7: 3338387-7.patch, failed testing. View results β
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- Status changed to Needs work
over 1 year ago 3:20pm 3 February 2023