- Issue created by @project update bot
This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.
Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.
Therefore these changes did not update the
info.yml
file for Drupal 11 compatibility.Leaving this issue open, even after committing the current patch, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug info
Bot run #11-121090This patch was created using these packages:
- drupal/upgrade_status: 4.1.0
- mglaman/phpstan-drupal: 1.2.7
- palantirnet/drupal-rector: 0.20.1
-
borisson_ →
committed 86ed03b5 on 2.0.x
Issue #3430401: Automated Drupal 11 compatibility fixes for facets
-
borisson_ →
committed 86ed03b5 on 2.0.x
-
borisson_ →
committed b578813c on 3.0.x
Issue #3430401: Automated Drupal 11 compatibility fixes for facets
-
borisson_ →
committed b578813c on 3.0.x
- Status changed to Needs work
8 months ago 1:29pm 10 April 2024 - 🇺🇸United States smustgrave
For D11 I would actually consider a 4.x branch that you can drop D9 and just support D10 and D11
- 🇮🇳India ankitv18
ankitv18 → changed the visibility of the branch project-update-bot-only to hidden.
- Status changed to Needs review
6 months ago 11:32am 19 June 2024 - Status changed to RTBC
5 months ago 10:44am 24 June 2024 - 🇧🇪Belgium svendecabooter Gent
I checked the MR and the changes seem correct.
- 🇧🇪Belgium borisson_ Mechelen, 🇧🇪
I think the mr needs to be rerolled?
- 🇧🇪Belgium svendecabooter Gent
I have rebased the branch on origin/2.0.x to include the fixes that were already committed there. They are no longer in the MR now.
This should be ready for merging in. -
borisson_ →
committed 74103165 on 2.0.x authored by
ankitv18 →
Issue #3430401 by ankitv18, Project Update Bot, svendecabooter,...
-
borisson_ →
committed 74103165 on 2.0.x authored by
ankitv18 →
- 🇧🇪Belgium borisson_ Mechelen, 🇧🇪
Merged in these changes, should we open a new branch for 3.x?
- 🇮🇳India ankitv18
@borrisson_ there's already a projectbot issue against 3.x https://www.drupal.org/project/facets/issues/3455217 📌 Automated Drupal 11 compatibility fixes for facets Active
And as in this MR minimum drupal support is 10 or should be cut a new branch from 2.x considering the comment of @smustgrave https://www.drupal.org/project/facets/issues/3455217 📌 Automated Drupal 11 compatibility fixes for facets Active
- Status changed to Fixed
5 months ago 1:23pm 27 June 2024 - 🇧🇪Belgium svendecabooter Gent
Marking this one as fixed, since https://www.drupal.org/project/facets/issues/3455217 📌 Automated Drupal 11 compatibility fixes for facets Active takes care of the 3.x D11 compatibility
Automatically closed - issue fixed for 2 weeks with no activity.