- Issue created by @project update bot
- last update
9 months ago 19 pass, 1 fail This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.
Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.
Therefore these changes did not update the
info.yml
file for Drupal 11 compatibility.Leaving this issue open, even after committing the current patch, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug info
Bot run #11-120024This patch was created using these packages:
- drupal/upgrade_status: 4.1.0
- mglaman/phpstan-drupal: 1.2.7
- palantirnet/drupal-rector: 0.20.1
The last submitted patch, 2: commerce_reports.8.x-1.x-dev.rector.patch, failed testing. View results →
- last update
8 months ago 19 pass, 1 fail This comment was forced and has ignored the check if a change was already posted. This is only done when we want to update the issue without waiting for changes to happen.
This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.
Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.
Therefore, these changes did not update the
info.yml
file for Drupal 11 compatibility.The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.
Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug information
Bot run #11-137198These packages were used to generate the fixes:
- drupal/upgrade_status: 4.1.0
- mglaman/phpstan-drupal: 1.2.10
- palantirnet/drupal-rector: 0.20.1
- Status changed to Needs review
8 months ago 2:21pm 4 April 2024 - last update
8 months ago 19 pass, 1 fail The last submitted patch, 4: commerce_reports.1.x-dev.rector.patch, failed testing. View results →
- First commit to issue fork.
- 🇫🇷France nicolasgraph Strasbourg
The test failure seems not related to the current issue ; updating the status to needs review for branch 3428485-manual-drupal-11.
- 🇩🇪Germany Anybody Porta Westfalica
Drupal 11 is out so this is important, also for Commerce 3.x compatibility. I think we should also add a 3.x branch here for clarification.
- Status changed to Needs review
5 days ago 3:31pm 29 November 2024 - Merge request !20Issue #3428485: Automated Drupal 11 compatibility fixes for commerce_reports → (Open) created by Grevil
- 🇩🇪Germany Grevil
There were a couple of issues with the original branch, I created a new one, with the D11 changes.
- 🇩🇪Germany Anybody Porta Westfalica
Nice @maintainers could you maybe create a 3.x branch to comply with commerce 3.x? Thanks!
- 🇩🇪Germany Grevil
Need maintainer feedback on https://git.drupalcode.org/project/commerce_reports/-/merge_requests/20#....
- 🇳🇴Norway zaporylie
All other issues are blocked by this one as tests are currently failing against D11. I left a comment on the MR (requested feedback).
- 🇩🇪Germany Grevil
Adjusted accordingly @zaporylie, let's see if the tests succeed.
- 🇩🇪Germany Grevil
I am fairly sure the test failures are unrelated, but I can't prove it. So back to NW because of the test failures.
- 🇫🇷France nicolasgraph Strasbourg
@grevil, not sure which of your MR is the one you're woking on but I think you should keep the change I made to ReportsListBuilder.php in the MR#18. See #3342975 📌 Deprecate Url::toRenderArray() and Url::renderAccess() Fixed + #3406432 📌 Remove calls of deprecated toRenderArray() method Fixed .