Offering to co-maintain Collapsiblock

Created on 13 March 2024, 3 months ago
Updated 9 June 2024, 17 days ago

I'm interested in supporting and maintaining this project. I plan to use it on my projects and continue working on improvements. I want to suggest to set up me as a co-maintainer. I investigated several issues and made several merge requests to improve the module.

https://www.drupal.org/project/collapsiblock/issues/3418361 πŸ“Œ Add and configure ESLint to GitLab test runner. Needs work
https://www.drupal.org/project/collapsiblock/issues/3418294 πŸ“Œ Fix test for D10 core Fixed
https://www.drupal.org/project/collapsiblock/issues/3418295 πŸ› stylelint Fixed
https://www.drupal.org/project/collapsiblock/issues/3407882 πŸ“Œ Add gitlab CI Needs work
https://www.drupal.org/project/collapsiblock/issues/3166181 ✨ Work with layout builder Needs work
https://www.drupal.org/project/collapsiblock/issues/3295655 πŸ“Œ Add tests for menu active trail support Needs work
https://www.drupal.org/project/collapsiblock/issues/3339359 πŸ’¬ Support Block Group module Active
https://www.drupal.org/project/collapsiblock/issues/3390571 πŸ’¬ Support facets_block module Active

πŸ’¬ Support request
Status

Postponed

Version

4.1

Component

Miscellaneous

Created by

πŸ‡ΊπŸ‡¦Ukraine Bobik

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @Bobik
  • Status changed to Postponed 3 months ago
  • πŸ‡¦πŸ‡ΊAustralia darvanen Sydney, Australia

    Thanks for the generous offer. I really appreciate the effort you are putting into this module, and I'm sorry that my schedule doesn't allow me to respond immediately.

    I've reviewed the contributions you've made to this module and I don't think they meet the requirements I'd be looking for in a co-maintainer. For example:

    • The test written in πŸ“Œ Add tests for menu active trail support Needs work may be passing but it is not testing the correct things.
    • The removal of the existing test in ✨ Work with layout builder Needs work demonstrated a bit of a misunderstanding of how layout builder works.
    • The various attempts to fix linting issues by ignoring them instead of addressing them demonstrated a lack of understanding of linting issues.

    I encourage you to continue helping out and we can revisit this application in a couple of months.

  • πŸ‡¦πŸ‡ΊAustralia darvanen Sydney, Australia

    I will definitely consider co-maintainership if you can solve #936984: New graphic for open and close β†’ in a robust and flexible way.

    If this issue was a way to ask me for more support, please feel free to close it. I will do so after a few months if there's no further action here :)

  • πŸ‡ΊπŸ‡¦Ukraine Bobik

    Hi @darvanen

    I will try to solve this problem.
    Please comment on my questions that I left in it

  • πŸ‡¦πŸ‡ΊAustralia darvanen Sydney, Australia

    Gladly.

    However I am on vacation at the moment, I do not know if I will have the attention for it. Please give me a couple of weeks grace just in case ☺️

Production build 0.69.0 2024