- Issue created by @bobi-mel
- Status changed to Postponed
about 1 year ago 12:08am 14 March 2024 - π¦πΊAustralia darvanen Sydney, Australia
Thanks for the generous offer. I really appreciate the effort you are putting into this module, and I'm sorry that my schedule doesn't allow me to respond immediately.
I've reviewed the contributions you've made to this module and I don't think they meet the requirements I'd be looking for in a co-maintainer. For example:
- The test written in π Add tests for menu active trail support Needs work may be passing but it is not testing the correct things.
- The removal of the existing test in β¨ Work with layout builder Needs work demonstrated a bit of a misunderstanding of how layout builder works.
- The various attempts to fix linting issues by ignoring them instead of addressing them demonstrated a lack of understanding of linting issues.
I encourage you to continue helping out and we can revisit this application in a couple of months.
- π¦πΊAustralia darvanen Sydney, Australia
I will definitely consider co-maintainership if you can solve β¨ New graphic for open and close Active in a robust and flexible way.
If this issue was a way to ask me for more support, please feel free to close it. I will do so after a few months if there's no further action here :)
- πΊπ¦Ukraine bobi-mel
Hi @darvanen
I will try to solve this problem.
Please comment on my questions that I left in it - π¦πΊAustralia darvanen Sydney, Australia
Gladly.
However I am on vacation at the moment, I do not know if I will have the attention for it. Please give me a couple of weeks grace just in case βΊοΈ
- Status changed to Needs review
12 days ago 2:11am 24 May 2025 - π¦πΊAustralia darvanen Sydney, Australia
Hi @bobi-mel,
After working with you on β¨ New graphic for open and close Active I'm happy to give you restricted co-maintainership of this module as I can see the effort you are putting in but I think some guard rails are still warranted.
If you still want to be involved I can give you access to write to VCS and maintain issues. This will give you the ability to commit changes to the main repo, however I will reserve "Administer Releases" for now as I want to check before we release.
- πΊπ¦Ukraine bobi-mel
Yes. Sure, I want to be a co-maintainer of the module.
I guess reserving "Administer Releases" for you is a good idea.