- Issue created by @bobi-mel
- last update
11 months ago 10 fail - last update
11 months ago 10 fail - last update
11 months ago 10 fail - last update
11 months ago 10 fail - last update
11 months ago 10 fail - 🇺🇦Ukraine bobi-mel
I have fixed the eslint comment for the gulpfile.js file. However, I encountered the problem "Unable to resolve path to module" in the Drupal core, which was solved with the help of the file's eslintignor. I have checked Gulp after the changes works well, but to eliminate comments, I follow the example of the kernel and include this file in the ignore.
- last update
11 months ago 10 fail - last update
11 months ago 10 fail - last update
11 months ago 10 fail - last update
11 months ago 10 fail - Issue was unassigned.
- Status changed to Needs review
11 months ago 11:29am 3 February 2024 - Status changed to RTBC
10 months ago 7:06am 28 February 2024 - 🇮🇳India d-xpert Chandigarh
I have reviewed the changes and tested them in my Drupal 10 DDEV environment. They appear to be okay, and the last GitLab CI run did not flag any new ESLint errors or warnings.
Moving to RTBC. - First commit to issue fork.
- last update
9 months ago 10 fail - last update
9 months ago 10 fail - last update
9 months ago 10 fail - Status changed to Needs work
9 months ago 11:49pm 13 March 2024 - 🇦🇺Australia darvanen Sydney, Australia
Why edit the gulpfile then ignore it?
I have installed eslint and required plugins in the theme, added core config, updated all libraries and rebuilt the theme.
- last update
9 months ago 10 fail - 🇦🇺Australia darvanen Sydney, Australia
Runner didn't like me using the core config: https://git.drupalcode.org/project/collapsiblock/-/jobs/1060423
I've removed eslint for now, the changes made to source files should be enough, I hope.
- 🇦🇺Australia darvanen Sydney, Australia
Ok that has properly broken it.
We might need to redefine the eslint job for this module.
Going to concentrate on 📌 Add gitlab CI Needs work now and leave this open to ADD eslint job later.
- 🇦🇺Australia darvanen Sydney, Australia
Perhaps a good place to start would be on some of the larger contrib modules like webform to see if they have solved this.
- 🇦🇺Australia darvanen Sydney, Australia
So much happened since this was opened and I moved some of the work from here to the CI ticket so I've opened a fresh branch directly from 4.x so please use MR 25 going forward. I'm going to check if any of the remaining work here can be moved in to that.
- Status changed to Needs review
9 months ago 6:52am 23 March 2024 - 🇦🇺Australia darvanen Sydney, Australia
I've resorted to ignoring the module import lines since it's core that's running eslint and it's not picking up our packages.
Tests are all passing but I would like a manual test to make triple sure this is still functioning correctly since I completely replaced the compiler.
- 🇦🇺Australia darvanen Sydney, Australia
Passes manual testing and everything is green except phpstan (next major) which has a separate issue open.
- Status changed to RTBC
9 months ago 7:32am 23 March 2024 -
darvanen →
committed 9257fec0 on 4.x
Issue #3418361 by darvanen, bobi-mel: Add and configure ESLint to GitLab...
-
darvanen →
committed 9257fec0 on 4.x
- Status changed to Fixed
9 months ago 7:33am 23 March 2024 - 🇦🇺Australia darvanen Sydney, Australia
Thanks very much for your work on this everyone!
Automatically closed - issue fixed for 2 weeks with no activity.