- Issue created by @deepakkm
- Assigned to bobi-mel
- last update
about 1 year ago 14 pass - 🇦🇺Australia darvanen Sydney, Australia
I have been meaning to do this but I admit it's a giant learning curve for me. If you've got the capacity to do more than plug the standard template in, I'd like to see:
- Remove all test runs for php <8.1
- Add tests for php 8.1 and 8.2
- Ensure functional tests are run - they're really important for this module
- Solve all script failures
- Issue was unassigned.
- Status changed to Needs review
about 1 year ago 12:10pm 29 January 2024 - 🇦🇺Australia darvanen Sydney, Australia
- 🇺🇦Ukraine bobi-mel
Hi @darvanen
You're absolutely right. I have assigned the issue to me and have not refreshed the page. I'll change the gitlab Ci file and fix all errors.
- Assigned to bobi-mel
- Status changed to Needs work
about 1 year ago 12:53pm 29 January 2024 - last update
about 1 year ago 14 pass - 🇺🇦Ukraine bohart Lutsk, Ukraine
Added a few comments for better future maintainability.
- last update
about 1 year ago 14 pass - last update
about 1 year ago 14 pass - 🇺🇦Ukraine bobi-mel
Hi @darvanen
Is it possible to create individual sub-tasks to solve script failures?
- last update
about 1 year ago 14 pass - 🇦🇺Australia darvanen Sydney, Australia
Thanks @bohart, good feedback.
@bobi-mel can you think of a way to complete those sub-tasks without committing the gitlab pipeline? I don't want to switch to gitlab until it is as green as the current automated test suite.
For instance, could we disable phpstan checks or reduce the level for this issue and create a follow-up to implement them and do the cleanup at the same time?
- last update
about 1 year ago 14 pass - First commit to issue fork.
- last update
about 1 year ago 14 pass - last update
about 1 year ago 14 pass - last update
about 1 year ago 14 pass - Status changed to Needs review
11 months ago 12:34pm 1 March 2024 - Issue was unassigned.
- last update
11 months ago 14 pass - last update
11 months ago 10 fail - last update
11 months ago 14 pass - last update
11 months ago 14 pass - Status changed to Needs work
11 months ago 12:49am 14 March 2024 - 🇦🇺Australia darvanen Sydney, Australia
Why has this been set to 'needs review'? None of @bohart's comments have been addressed for starters.
- 🇦🇺Australia darvanen Sydney, Australia
I have made the D10 tests green, but I still maitnain that a parallel job with a matrix is unnecessary when the matrix only has one value. See how core does it on line 193+ of https://git.drupalcode.org/project/drupal/-/blob/11.x/.gitlab-ci.yml?ref...
It would be nice if someone addressed the cspell issues by ignoring the composer.json file and adding a few extra words to the dictionary. I've run out of time to figure out how to do that. Happy for it to be a follow-up instead.
- last update
11 months ago 14 pass - 🇦🇺Australia darvanen Sydney, Australia
Ok I finally went digging and learned how this stuff works properly. Turns out "OPT_IN_TEST_NEXT_MAJOR" from the template automatically tests the maximum version of PHP so we don't need any custom jobs to make that happen. We could use "OPT_IN_TEST_MAX_PHP" to *just* do PHP but I also want to support the next major.
I've also landed on an approach for this that I've used on two other modules so I'm updating the issue summary with that approach.
PHPStan is only failing on 'next major' so I'm happy to leave that one enabled since the current version one goes green.
- last update
11 months ago 14 pass - last update
11 months ago 14 pass -
darvanen →
committed 2f64ccab on 4.x authored by
bobi-mel →
Issue #3407882 by bobi-mel, darvanen, thakurnishant_06, deepakkm, bohart...
-
darvanen →
committed 2f64ccab on 4.x authored by
bobi-mel →
- Status changed to Fixed
11 months ago 1:20am 23 March 2024 - 🇦🇺Australia darvanen Sydney, Australia
Follow-ups:
📌 Add and configure ESLint to GitLab test runner. Needs work - existing, thanks @bobi-mel
📌 Fix and re-enable CSPell test Active
🐛 Drupal 11 PHPStan tests failing Active - 🇦🇺Australia darvanen Sydney, Australia
Thanks everyone for your work on this! I've merged this and disabled the old CI on this module.
-
darvanen →
committed db70b3e3 on 4.x
Issue #3407882 by darvanen, bobi-mel, thakurnishant_06, deepakkm, bohart...
-
darvanen →
committed db70b3e3 on 4.x
- 🇦🇺Australia darvanen Sydney, Australia
Snuck the next_minor job in on this issue to avoid giving myself another credit for just one line.
Automatically closed - issue fixed for 2 weeks with no activity.