stylelint

After adding the changes to the includes/include.drupalci.main.yml file, we can ignore the warnings for compiled files

see https://www.drupal.org/project/gitlab_templates/issues/3417807 →

Hi @bobi-mel, I really appreciate the time you're putting into this, thank you!

I've left one comment, I'll come back soon, (I hope withing 24h) to look again.

Hi
I've removed the neon file and added @phpstan-ignore-next-line

Needs to fix pipline issues.

Hi @ravi kant
I saw these issues when I started working on this issue. However, the eslint issues that are being ignored are related to compiled files. I haven't found a better solution to this problem yet.

The stylelint job failed because all files were ignored. I have changed the ".scss" files to ".css" because they are not using any sass features.

Now that stylelint is running properly on the source files there are some issues to be fixed:

theme/src/css/collapsiblock-rtl.css
 3:3  ✖  Expected "display" to come before "background"  order/properties-order
theme/src/css/collapsiblock.css
 3:3  ✖  Expected "display" to come before "background"  order/properties-order
 5:3  ✖  Expected "padding" to come before "border"      order/properties-order
 7:3  ✖  Expected "width" to come before "cursor"        order/properties-order
4 problems (4 errors, 0 warnings)
2 sources checked
 /builds/project/collapsiblock/web/modules/custom/collapsiblock/theme/src/css/collapsiblock-rtl.css
 /builds/project/collapsiblock/web/modules/custom/collapsiblock/theme/src/css/collapsiblock.css

I have:

• installed stylelint
• copied .stylelintrc from core and made a couple of small adjustments to get it to run
• run the automatic fixes
• rebuilt the compiled css files

gitlab runner didn't pick up the stylelintignore file inside the theme folder, so now we need one at module root as well as inside the theme folder for when running gulp.

Stylelint passed: https://git.drupalcode.org/project/collapsiblock/-/jobs/1059765

Now to remove the unrelated changes that are still being worked on in other issues.

Automatically closed - issue fixed for 2 weeks with no activity.