Fix test for D10 core

The current test system is passing on D10:

https://www.drupal.org/pift-ci-job/2848692 →

So what is different about running it on gitlab?

Hi @
Comment#2darvanen

We have the following
- all testing of modules will migrate to Drupal GitLab CI
- the process of testing is more flexible
- run tests more fast (it is very useful)
more details here - https://www.drupal.org/about/core/blog/drupal-cores-gitlab-ci-testing-is... →

I've fixed the test. Please check it

Thanks @bobi-mel, finally got to this. Please see my comment, I may be off the mark but I'd like your input.

I realise I have started a conversation here about the contents of the gitlab-ci.yml file which rightly belongs in 📌 Add gitlab CI Needs work . So I'm removing that file from this branch so we can commit the fixes to the tests themselves. I will move my comments there.

There were two errors when I merged this into 📌 Add gitlab CI Needs work :

1) Drupal\Tests\collapsiblock\Functional\BlockInstanceTest::testBlockInstanceConfigForm
TypeError: Behat\Mink\Element\TraversableElement::findButton(): Argument #1 ($locator) must be of type string, Drupal\Core\StringTranslation\TranslatableMarkup given, called in /builds/project/collapsiblock/web/core/tests/Drupal/Tests/WebAssert.php on line 143
/builds/project/collapsiblock/vendor/behat/mink/src/Element/TraversableElement.php:97
/builds/project/collapsiblock/web/core/tests/Drupal/Tests/WebAssert.php:143
/builds/project/collapsiblock/web/core/tests/Drupal/Tests/UiHelperTrait.php:78
/builds/project/collapsiblock/tests/src/Functional/BlockInstanceTest.php:62
/builds/project/collapsiblock/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
2) Drupal\Tests\collapsiblock\Functional\GlobalConfigurationTest::testGlobalConfigForm
TypeError: Behat\Mink\Element\TraversableElement::findButton(): Argument #1 ($locator) must be of type string, Drupal\Core\StringTranslation\TranslatableMarkup given, called in /builds/project/collapsiblock/web/core/tests/Drupal/Tests/WebAssert.php on line 143
/builds/project/collapsiblock/vendor/behat/mink/src/Element/TraversableElement.php:97
/builds/project/collapsiblock/web/core/tests/Drupal/Tests/WebAssert.php:143
/builds/project/collapsiblock/web/core/tests/Drupal/Tests/UiHelperTrait.php:78
/builds/project/collapsiblock/tests/src/Functional/GlobalConfigurationTest.php:72
/builds/project/collapsiblock/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

Actually let's address them in that issue.

Automatically closed - issue fixed for 2 weeks with no activity.