- πΊπ¦Ukraine Bobik
Hi @darvanen
I will try to solve this problem. However, in order not to waste time, I would like to clarify some details:
1) If possible, please provide an example of the future chart;
2) What behavior do you expect the chart to have?
3) The Acquia slate theme is outdated, what theme will we use to test the results?
4) Add important points to consider while working on the task;
5) Your suggestions for the final result of the assignment.Thank you!
- π¦πΊAustralia darvanen Sydney, Australia
@bobi-mel, answers to your questions:
- I'm sorry but I don't understand what you mean by "chart" here?
- Same issue.
- I think Gin theme has a dark mode and is quite popular, let's see if that meets our needs.
- I don't have any specific points to make, just try to uphold Drupal's values.
As for 5, here's my current vision:
- Replace the current .png images with .svg images with
fill="currentColor"
. - Provide an interface where the admin can set the color of the indicator.
- Write a test for the new feature.
Bonus points for:
- Provide additional built-in glyph options commonly used for dropdowns.
- Create optional integrations with fontawesome β and/or material_icons β (probably better as a follow-up).
I am very happy to discuss if you have different ideas.
- πΊπ¦Ukraine Bobik
Hi @darvanen
1) I mean graphic not chart, sorry
2) I will investigate the issue and let you know my ideas to solve it.
- π¦πΊAustralia darvanen Sydney, Australia
@bobi-mel no apology needed, I can see it was just lost in translation.
2: Great, I look forward to hearing your ideas.
- Assigned to Bobik
- πΊπ¦Ukraine Bobik
Hi @darvanen
I tried to use the Gin theme β , but it is only an admin theme and can't be used for front-end part of the site.
I propose:
1) Add a new 'Dark mode' element to the module config form;
2) Also, Add text field 'Theme class for dark mode', because different themes add different custom classes the Body or HTML tag.
4) Use existing behavior if added theme dark mode class and enabled dark mode for module set the class 'collapsiblock-dark-mode' to the block title;
5) Create two SVG images for each type of arrow: dark and white;
6) By default use dark.
7) Use these arrows - https://www.svgrepo.com/svg/393200/triangle-down-filled as more modern.Let me know what you think about it
- π¦πΊAustralia darvanen Sydney, Australia
Nice ideas @bobi-mel, on the whole I think that sounds good, the only thing I would add is to use form states to make the text field only visible if the checkbox is selected.
I don't see why we can't test it with an admin theme?
- πΊπ¦Ukraine Bobik
I thought it over and agree with you the Git theme will be good for a test.