New graphic for open and close

Created on 9 October 2010, over 13 years ago
Updated 25 June 2024, about 20 hours ago

Hi. Collapsiblock is working great for me, but i can barely see the graphics on a black theme (Acquia slate).

As I'm pretty weak when it comes to graphics, I'm wondering if has anyone has made new versions of the graphics, but in white.

✨ Feature request
Status

Active

Version

4.0

Component

User interface

Created by

πŸ‡¨πŸ‡¦Canada dpatte

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡ΊπŸ‡¦Ukraine Bobik

    Hi @darvanen

    I will try to solve this problem. However, in order not to waste time, I would like to clarify some details:

    1) If possible, please provide an example of the future chart;
    2) What behavior do you expect the chart to have?
    3) The Acquia slate theme is outdated, what theme will we use to test the results?
    4) Add important points to consider while working on the task;
    5) Your suggestions for the final result of the assignment.

    Thank you!

  • πŸ‡¦πŸ‡ΊAustralia darvanen Sydney, Australia

    @bobi-mel, answers to your questions:

    1. I'm sorry but I don't understand what you mean by "chart" here?
    2. Same issue.
    3. I think Gin theme has a dark mode and is quite popular, let's see if that meets our needs.
    4. I don't have any specific points to make, just try to uphold Drupal's values.

    As for 5, here's my current vision:

    • Replace the current .png images with .svg images with fill="currentColor".
    • Provide an interface where the admin can set the color of the indicator.
    • Write a test for the new feature.

    Bonus points for:

    I am very happy to discuss if you have different ideas.

  • πŸ‡ΊπŸ‡¦Ukraine Bobik

    Hi @darvanen

    1) I mean graphic not chart, sorry

    2) I will investigate the issue and let you know my ideas to solve it.

  • πŸ‡¦πŸ‡ΊAustralia darvanen Sydney, Australia

    @bobi-mel no apology needed, I can see it was just lost in translation.

    2: Great, I look forward to hearing your ideas.

  • Assigned to Bobik
  • πŸ‡ΊπŸ‡¦Ukraine Bobik
  • πŸ‡ΊπŸ‡¦Ukraine Bobik

    Hi @darvanen

    I tried to use the Gin theme β†’ , but it is only an admin theme and can't be used for front-end part of the site.

    I propose:
    1) Add a new 'Dark mode' element to the module config form;
    2) Also, Add text field 'Theme class for dark mode', because different themes add different custom classes the Body or HTML tag.
    4) Use existing behavior if added theme dark mode class and enabled dark mode for module set the class 'collapsiblock-dark-mode' to the block title;
    5) Create two SVG images for each type of arrow: dark and white;
    6) By default use dark.
    7) Use these arrows - https://www.svgrepo.com/svg/393200/triangle-down-filled as more modern.

    Let me know what you think about it

  • πŸ‡¦πŸ‡ΊAustralia darvanen Sydney, Australia

    Nice ideas @bobi-mel, on the whole I think that sounds good, the only thing I would add is to use form states to make the text field only visible if the checkbox is selected.

    I don't see why we can't test it with an admin theme?

  • πŸ‡ΊπŸ‡¦Ukraine Bobik

    I thought it over and agree with you the Git theme will be good for a test.

Production build 0.69.0 2024