Enable keyboard users to expand and collapse submenus also when the navigation is collapsed

Added a fix for this. Now, if the navbar is collapsed and you navigate with the keyboard, the submenus will open when you press ENTER. If you press ENTER again or if pressing Shift + Tab before focusing on the submenu, it will close.

ahsannazir → made their first commit to this issue’s fork.

The keyboard navigation is now working fine. I just fixed some linting prettier errors. Attaching screen recording for reference

Thank you @Silviu S. for the initial patch! I've manually tested the latest state to the MR including the changes from @ehsann_95. A few observations and thoughts:

The MR solves the problem of the tabbing order if the navigation is collapsed. You are now able to tab back and forth through the top level items as long as you don't expand one of the available sub menus by pressing the return button or spacebar.

The only problem i see (probably out of the scope for this issue but might justify a follow up issue), at the moment there is no direct visual cue for sighted keyboard users if a menu item has a submenu or not. This detail is currently only communicated indirectly, menu items without a submenu show some sort of "tooltip" with a black background showing the name/label of the menu item. That is the same behavior as on hover, the only difference, for top level menu items with a submenu, that submenu is directly shown on hover, while the submenu has the name/label of the parent top level menu item on top.
So it might be useful to have such sort of label in the form of the black tooltip for top level menu items that have a submenu but at the same time to provide some sort of visual cue that helps to directly identify top level menu items that have a submenu.

And I wonder if it would make sense to add (at least for the collapsed navigation state but probably might make sense for the expanded state as well?) to add the option for the user that pressing the esc key closes an open submenu and the focus returns to the parent top level menu item?

@ahsannazir thank you for your update. Tested it and everything seems fine.

@Silviu S. hello! thank you for work!

One thing here. Could you please provide MR without formatting fix? only real changes. It seems impossible to review what was changed

@finnsky @SilviuS
yes #7 clearly says it was just formatting. i've reverted that commit.

Looks good to me.
Moving back to RTBC. Thanks everyone!

ckrina → closed merge request !190

ckrina → reopened merge request !190

Thanks all! Merged :)

@rkoller noting all your ideas in #9. This week we're going to start implementing the new designs and hopefully we can implement them there: the interactions will change slightly, that's why I've merged this already so we iterate piece by piece.

Automatically closed - issue fixed for 2 weeks with no activity.