Update `type: field.formatter.settings.file_video` to match the validation logic in FileVideoFormatter's settings form

core.entity_view_display.media.video.default uses type: field.formatter.settings.file_video.

So let's check validatability of that concrete config using ./vendor/bin/drush config:inspect --filter-keys=core.entity_view_display.media.video.default --detail --list-constraints:

• Before: 62% validatable.
• After: 68% validatable.

To mark type: field.formatter.settings.file_video fully validatable, we also need to ensure that the type it extends is fully validatable. That's type: file.formatter.media.

Fortunately, that one is also trivial to validate! 😄

Using ./vendor/bin/drush config:inspect --filter-keys=core.entity_view_display.media.video.default --detail --list-constraints again:

• Before: 68% validatable
• After: 70% validatable

Let's now have "Follow .." in the git commit message. Although I am not sure what field.formatter.settings.file_video is supposed to match :-(. So, I am tagging for a title update.

The thing you removed from the title actually made that clear 😅

Either way: done 😊, and I'll stop using that prefix — sorry about that! 🫣

Left a small comment on MR.

I did think there may be config schema implications before I committed that issue, but thought if that were the case the tests should have failed. Any idea why they didn't?

#8:

Any idea why they didn't?

1. Because config in core is not validated at all. Only basic conformance to the storage types is checked by ConfigSchemaChecker.
2. Because none of the config in core is actually invalid 😄👍 (the only config using this: core.entity_view_display.media.video.default.yml)

I should of said it out loud, min of 0 haha

Changing the form min/max makes sense.

I could also argue that a 1px video doesn't make much sense but I suppose we have to draw the line somewhere :)

Committed and pushed 6e7fa7f365 to 11.x and 106d55288c to 10.3.x. Thanks!

longwave → closed merge request !6882

@longwave Absolutely! 😄 That's IMHO material for the future; because imposing sensible limits is more likely to need update paths/break BC 🫣

Automatically closed - issue fixed for 2 weeks with no activity.