Umami views should use responsive grid

Created on 2 March 2024, 9 months ago
Updated 4 June 2024, 6 months ago

Problem/Motivation

Umami uses themed unformatted lists to get a 'responsive grid layout', but since 10.0.0, we've had an actual responsive grid in core, so we should use that instead.

If we're lucky, this might just be reconfiguring the views, then locating and deleting any unnecessary CSS.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

📌 Task
Status

Fixed

Version

10.3

Component
Umami 

Last updated 28 days ago

Created by

🇬🇧United Kingdom catch

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @catch
  • Status changed to Needs work 9 months ago
  • 🇬🇧United Kingdom catch

    Found various unformatted lists that are simulating a grid, as well as the legacy views grid style.

    Converted all of these in the MR but have not touched the CSS.

    The recipes collection looks broken now - the links are green, probably needs a class or two changing.

    I'm sure we can remove some now-unnecessary CSS that was styling the unformatted lists but will leave that to the interested reader since CSS isn't my strength.

  • 🇬🇧United Kingdom catch
  • Pipeline finished with Failed
    9 months ago
    Total: 172s
    #114536
  • Pipeline finished with Success
    9 months ago
    Total: 481s
    #114594
  • 🇷🇸Serbia finnsky

    Gonna check css here

  • Pipeline finished with Success
    9 months ago
    Total: 510s
    #118458
  • Pipeline finished with Failed
    9 months ago
    Total: 179s
    #118518
  • Status changed to Needs review 9 months ago
  • 🇷🇸Serbia finnsky

    Great initiative!

    • I've added 2 more views configs. They should follow same responsive grid
    • Removed outdated css grids.
    • Fixed css
    • Modernized css for promoted view. Article page grid. For me it is easier to manage all together. It can be moved to new issue.

    Please review

  • Pipeline finished with Failed
    9 months ago
    Total: 517s
    #118525
  • Status changed to Needs work 9 months ago
  • 🇺🇸United States smustgrave

    Nice! Appears to have test failures though :(

  • Pipeline finished with Failed
    9 months ago
    #118894
  • Pipeline finished with Failed
    9 months ago
    Total: 474s
    #118902
  • Pipeline finished with Failed
    9 months ago
    #118924
  • 🇷🇸Serbia finnsky

    Something wrong here with css_class schema. tried with both boolean and false.

  • 🇬🇧United Kingdom catch

    views config schema says it should be boolean - did you try installing and then re-exporting the view?

  • 🇷🇸Serbia finnsky

    seems that css class should be configured in admin ui and then reexported. probably it will help

  • Pipeline finished with Failed
    8 months ago
    Total: 662s
    #136020
  • Pipeline finished with Success
    8 months ago
    Total: 630s
    #136035
  • Status changed to Needs review 8 months ago
  • 🇷🇸Serbia finnsky

    All green!

  • 🇬🇧United Kingdom catch

    I'm not qualified to review the actual CSS changes here, but the net reduction is great and shows just what an excellent feature responsive grid is!

  • 🇬🇧United Kingdom catch

    Rebased, pretty sure this will fail performance tests now for Umami since CSS coverage for added - but we just need to reduce the CSS byte assertions because there'll be less. Having trouble with chromedriver locally at the moment so letting gitlab tell us the new numbers.

  • Pipeline finished with Canceled
    8 months ago
    #141737
  • 🇬🇧United Kingdom catch

    Back to green :)

  • Pipeline finished with Success
    8 months ago
    Total: 965s
    #141758
  • Status changed to Needs work 8 months ago
  • The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

    This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

    Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

  • Pipeline finished with Success
    7 months ago
    Total: 494s
    #158124
  • Status changed to Needs review 7 months ago
  • Pipeline finished with Failed
    7 months ago
    Total: 179s
    #161748
  • Pipeline finished with Failed
    7 months ago
    Total: 506s
    #162171
  • Status changed to Needs work 7 months ago
  • 🇺🇸United States smustgrave

    Seems to have failures in the openTelemetry tests which I believe (correct me if I'm wrong) isn't random.

  • 🇬🇧United Kingdom catch

    It's fine to set the ceiling on the OpenTelemetry tests 500k higher than whatever the eventual number is, that way other small CSS/JS changes won't cause this MR to fail.

  • Pipeline finished with Canceled
    7 months ago
    Total: 185s
    #168865
  • Status changed to Needs review 7 months ago
  • Pipeline finished with Success
    7 months ago
    Total: 563s
    #168875
  • Status changed to RTBC 7 months ago
  • 🇺🇸United States smustgrave

    Finally got around to this one

    Did a fresh Umami install without the MR applied to verify column shifts on pages like /articles

    Did a fresh Umami install with the MR already applied so the config imported
    Visited /articles page to verify the layout is the same and responsive at various breakpoints

    Then I did the same for the homepage as I saw that view was updated.
    Also did not notice any issue.

    Believe this is a good replacement.

    • nod_ committed b6026c12 on 10.3.x
      Issue #3425104 by finnsky, catch, smustgrave: Umami views should use...
    • nod_ committed 57a0cd75 on 10.4.x
      Issue #3425104 by finnsky, catch, smustgrave: Umami views should use...
    • nod_ committed f607b858 on 11.0.x
      Issue #3425104 by finnsky, catch, smustgrave: Umami views should use...
    • nod_ committed 587350c2 on 11.x
      Issue #3425104 by finnsky, catch, smustgrave: Umami views should use...
  • Status changed to Fixed 7 months ago
  • 🇫🇷France nod_ Lille

    Since this only impacting umami I'm backporting back to 10.3.x

    Committed and pushed 587350c208 to 11.x and f607b858d6 to 11.0.x and 57a0cd753d to 10.4.x and b6026c1215 to 10.3.x. Thanks!

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024