Umami views should use responsive grid

Created on 2 March 2024, about 1 month ago
Updated 10 April 2024, 3 days ago

Problem/Motivation

Umami uses themed unformatted lists to get a 'responsive grid layout', but since 10.0.0, we've had an actual responsive grid in core, so we should use that instead.

If we're lucky, this might just be reconfiguring the views, then locating and deleting any unnecessary CSS.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

📌 Task
Status

Needs work

Version

11.0 🔥

Component
Umami 

Last updated 3 days ago

Created by

🇬🇧United Kingdom catch

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @catch
  • Status changed to Needs work about 1 month ago
  • 🇬🇧United Kingdom catch

    Found various unformatted lists that are simulating a grid, as well as the legacy views grid style.

    Converted all of these in the MR but have not touched the CSS.

    The recipes collection looks broken now - the links are green, probably needs a class or two changing.

    I'm sure we can remove some now-unnecessary CSS that was styling the unformatted lists but will leave that to the interested reader since CSS isn't my strength.

  • Pipeline finished with Failed
    about 1 month ago
    Total: 172s
    #114536
  • Pipeline finished with Success
    about 1 month ago
    Total: 481s
    #114594
  • 🇷🇸Serbia finnsky

    Gonna check css here

  • Pipeline finished with Success
    about 1 month ago
    Total: 510s
    #118458
  • Pipeline finished with Failed
    about 1 month ago
    Total: 179s
    #118518
  • Status changed to Needs review about 1 month ago
  • 🇷🇸Serbia finnsky

    Great initiative!

    • I've added 2 more views configs. They should follow same responsive grid
    • Removed outdated css grids.
    • Fixed css
    • Modernized css for promoted view. Article page grid. For me it is easier to manage all together. It can be moved to new issue.

    Please review

  • Pipeline finished with Failed
    about 1 month ago
    Total: 517s
    #118525
  • Status changed to Needs work about 1 month ago
  • 🇺🇸United States smustgrave

    Nice! Appears to have test failures though :(

  • Pipeline finished with Failed
    30 days ago
    #118894
  • Pipeline finished with Failed
    30 days ago
    Total: 474s
    #118902
  • Pipeline finished with Failed
    30 days ago
    #118924
  • 🇷🇸Serbia finnsky

    Something wrong here with css_class schema. tried with both boolean and false.

  • 🇬🇧United Kingdom catch

    views config schema says it should be boolean - did you try installing and then re-exporting the view?

  • 🇷🇸Serbia finnsky

    seems that css class should be configured in admin ui and then reexported. probably it will help

  • Pipeline finished with Failed
    10 days ago
    Total: 662s
    #136020
  • Pipeline finished with Success
    10 days ago
    Total: 630s
    #136035
  • Status changed to Needs review 10 days ago
  • 🇷🇸Serbia finnsky

    All green!

  • 🇬🇧United Kingdom catch

    I'm not qualified to review the actual CSS changes here, but the net reduction is great and shows just what an excellent feature responsive grid is!

  • 🇬🇧United Kingdom catch

    Rebased, pretty sure this will fail performance tests now for Umami since CSS coverage for added - but we just need to reduce the CSS byte assertions because there'll be less. Having trouble with chromedriver locally at the moment so letting gitlab tell us the new numbers.

  • Pipeline finished with Canceled
    4 days ago
    #141737
  • 🇬🇧United Kingdom catch

    Back to green :)

  • Pipeline finished with Success
    4 days ago
    Total: 965s
    #141758
  • Status changed to Needs work 3 days ago
  • The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

    This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

    Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

Production build https://api.contrib.social 0.62.1