- Issue created by @catch
- Status changed to Needs work
9 months ago 10:20am 8 March 2024 - 🇬🇧United Kingdom catch
Found various unformatted lists that are simulating a grid, as well as the legacy views grid style.
Converted all of these in the MR but have not touched the CSS.
The recipes collection looks broken now - the links are green, probably needs a class or two changing.
I'm sure we can remove some now-unnecessary CSS that was styling the unformatted lists but will leave that to the interested reader since CSS isn't my strength.
- Merge request !6970Configure various Umami views to use responsive grid. → (Closed) created by catch
- Status changed to Needs review
9 months ago 7:05pm 13 March 2024 - 🇷🇸Serbia finnsky
Great initiative!
- I've added 2 more views configs. They should follow same responsive grid
- Removed outdated css grids.
- Fixed css
- Modernized css for promoted view. Article page grid. For me it is easier to manage all together. It can be moved to new issue.
Please review
- Status changed to Needs work
9 months ago 12:44am 14 March 2024 - 🇷🇸Serbia finnsky
Something wrong here with css_class schema. tried with both boolean and false.
- 🇬🇧United Kingdom catch
views config schema says it should be boolean - did you try installing and then re-exporting the view?
- 🇷🇸Serbia finnsky
seems that css class should be configured in admin ui and then reexported. probably it will help
- Status changed to Needs review
8 months ago 8:07am 3 April 2024 - 🇬🇧United Kingdom catch
I'm not qualified to review the actual CSS changes here, but the net reduction is great and shows just what an excellent feature responsive grid is!
- 🇬🇧United Kingdom catch
Rebased, pretty sure this will fail performance tests now for Umami since CSS coverage for added - but we just need to reduce the CSS byte assertions because there'll be less. Having trouble with chromedriver locally at the moment so letting gitlab tell us the new numbers.
- Status changed to Needs work
8 months ago 12:08pm 10 April 2024 The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
7 months ago 8:01am 27 April 2024 - Status changed to Needs work
7 months ago 2:46pm 9 May 2024 - 🇺🇸United States smustgrave
Seems to have failures in the openTelemetry tests which I believe (correct me if I'm wrong) isn't random.
- 🇬🇧United Kingdom catch
It's fine to set the ceiling on the OpenTelemetry tests 500k higher than whatever the eventual number is, that way other small CSS/JS changes won't cause this MR to fail.
- Status changed to Needs review
7 months ago 3:32pm 9 May 2024 - Status changed to RTBC
7 months ago 5:53pm 14 May 2024 - 🇺🇸United States smustgrave
Finally got around to this one
Did a fresh Umami install without the MR applied to verify column shifts on pages like /articles
Did a fresh Umami install with the MR already applied so the config imported
Visited /articles page to verify the layout is the same and responsive at various breakpointsThen I did the same for the homepage as I saw that view was updated.
Also did not notice any issue.Believe this is a good replacement.
- Status changed to Fixed
7 months ago 2:17pm 21 May 2024 - 🇫🇷France nod_ Lille
Since this only impacting umami I'm backporting back to 10.3.x
Committed and pushed 587350c208 to 11.x and f607b858d6 to 11.0.x and 57a0cd753d to 10.4.x and b6026c1215 to 10.3.x. Thanks!
Automatically closed - issue fixed for 2 weeks with no activity.