- Issue created by @joachim
- ๐ฎ๐ณIndia prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan
Prem Suthar โ made their first commit to this issueโs fork.
- Merge request !6723200~drupal-3422919/3422919-error-in-docs - Fix the doc comment by remove the... โ (Open) created by prem suthar
- Status changed to Needs work
11 months ago 2:04pm 21 February 2024 - ๐ฌ๐งUnited Kingdom joachim
Thanks for the MR!
Could you just fix the one problem for this issue though, rather than expand the scope?
I am going to be filing an issue to fix the confusing use of 'component' to mean extensions, but it's going to involve method renaming too.
- Status changed to Needs review
11 months ago 2:37pm 21 February 2024 - Status changed to Needs work
11 months ago 3:59pm 21 February 2024 - ๐บ๐ธUnited States smustgrave
@Prem Suthar just FYI this was tagged for novice, meaning for new users to Drupal contribution, and based on your post history believe you could work on non novice issues please.
Believe the goal was just to update getComponentNames function.
- ๐ฌ๐งUnited Kingdom joachim
I think we could expand the scope to include the other error that @Prem Suthar spotted, which is that the structure of the @param array is incorrectly documented:
> Array of component lists indexed by type
However, the current MR is removing the '(optional)' part.
I've filed ๐ Fix incorrect use of word 'component' in locale module Active , which is a bigger task which covers both code and docs.
- ๐ฌ๐งUnited Kingdom joachim
Hmm on second thoughts,
> Array of component lists indexed by type
does sort of describe it -- it's an array of several lists, and the array is keyed by the type of the things in the list.
The other issue is going to rewrite that text anyway so let's just fix the incorrect 'update' here.
- ๐ธ๐ฌSingapore Lee Jun Long
Hi, I am looking into this issue queue as part of Drupalcon Singapore 2024 Contribution day, and hope I can contribute in one way or another.
I have made a fresh installation of a Drupal 11 site to check on this, and tried to search the codebase for the code block shown in the Problem/Motivation. I realised that the only location I can find comes from
core/modules/locale/src/LocaleConfigManager.php
. I checked that merge requestMR !6723
, and found that the MR includes changes to bothcore/modules/locale/src/LocaleConfigManager.php
andcore/modules/locale/locale.bulk.inc
. This confused me as I didn't understand the current state of the issue queue, and how I can contribute further. - ๐ฌ๐งUnited Kingdom joachim
It's core/modules/locale/src/LocaleConfigManager.php that needs fixing.
- ๐ฎ๐ณIndia adwivedi008
adwivedi008 โ changed the visibility of the branch 3422919-error-in-docs to hidden.
- ๐ฎ๐ณIndia adwivedi008
adwivedi008 โ changed the visibility of the branch 3422919-error-in-docs to active.
- ๐ฎ๐ณIndia adwivedi008
adwivedi008 โ changed the visibility of the branch 3422919-error-in-docs to hidden.
- ๐ฎ๐ณIndia adwivedi008
adwivedi008 โ changed the visibility of the branch 3422919-error-in-docs to hidden.
- ๐ฎ๐ณIndia adwivedi008
adwivedi008 โ changed the visibility of the branch 3422919-error-in-docs to active.
- ๐ฎ๐ณIndia adwivedi008
adwivedi008 โ changed the visibility of the branch 3422919-error-in-docs to hidden.
- ๐ฎ๐ณIndia adwivedi008
adwivedi008 โ changed the visibility of the branch 3422919-error-in-docs to active.
- ๐ฎ๐ณIndia adwivedi008
Reverted the out-of-scope changes.
please review - ๐บ๐ธUnited States smustgrave
Issue summary for good practice should still be filled out.
Also the parameter is still optional.