- Issue created by @larowlan
- Assigned to danielveza
- Merge request !6593[#3421019] - Convert Section storage annotations to attributes β (Open) created by danielveza
- Status changed to Needs review
about 1 year ago 6:45am 14 February 2024 - π³πΏNew Zealand danielveza Brisbane, AU
I've set up the SectionStorage Attribute and converted all existing plugins over to the Attribute. Tests green, Ready for review
- Status changed to Needs work
about 1 year ago 9:26pm 14 February 2024 - πΊπΈUnited States smustgrave
For the open threads. Leaving currently assigned assuming @DanielVeza you wanted to work on this one.
- π³πΏNew Zealand danielveza Brisbane, AU
Pushed up a commit that fixes most of the MR feedback. This is the leftover item, need to look into it more.
I think you can use EntityContextDefinition::fromEntityTypeId('entity_view_display') here to simplify
PHPStorm doesn't like it. I wonder if static functions aren't allowed here
- Status changed to Needs review
about 1 year ago 1:26am 15 February 2024 - π³πΏNew Zealand danielveza Brisbane, AU
Setting back to needs review. Resolved all threads except one, and left a comment about why that one may not work. Unless I'm misunderstanding something
- Status changed to Needs work
about 1 year ago 4:20pm 15 February 2024 - Status changed to Needs review
about 1 year ago 10:31pm 15 February 2024 - π³πΏNew Zealand danielveza Brisbane, AU
Agreed with the the last feedback item. Pushed up a commit, back to NR
- Status changed to Needs work
about 1 year ago 11:26pm 15 February 2024 - π¦πΊAustralia mstrelan
I think we need to document the params as per the annotation class.
- Status changed to Needs review
about 1 year ago 12:41am 16 February 2024 - Status changed to Needs work
about 1 year ago 3:25am 16 February 2024 - π¦πΊAustralia mstrelan
As per @larowlan I think we need to add
public readonly ?string $deriver = NULL
to the constructor params. - First commit to issue fork.
- Status changed to Needs review
about 1 year ago 9:22am 1 March 2024 - Status changed to Needs work
about 1 year ago 12:58pm 1 March 2024 - Status changed to Needs review
about 1 year ago 8:10am 2 March 2024 - Status changed to RTBC
about 1 year ago 6:21pm 2 March 2024 - First commit to issue fork.
- Status changed to Fixed
about 1 year ago 9:22am 8 March 2024 - π¬π§United Kingdom alexpott πͺπΊπ
Committed and pushed 4fcae3ca53 to 11.x and 31ec7d645e to 10.3.x. Thanks!
-
alexpott β
committed 31ec7d64 on 10.3.x
Issue #3421019 by DanielVeza, sorlov, andypost, smustgrave, larowlan,...
-
alexpott β
committed 31ec7d64 on 10.3.x
-
alexpott β
committed 4fcae3ca on 11.x
Issue #3421019 by DanielVeza, sorlov, andypost, smustgrave, larowlan,...
-
alexpott β
committed 4fcae3ca on 11.x
- π¦πΊAustralia kim.pepper πββοΈπ¦πΊSydney, Australia
Can someone close the MR?
Automatically closed - issue fixed for 2 weeks with no activity.