- Issue created by @larowlan
- 🇮🇳India mohit_aghera Rajkot
Note: BC approach to handle annotations and attributes in
MigratePluginManager
class is being evaluated in https://www.drupal.org/project/drupal/issues/3424509 📌 Update MigratePluginManager to include both attribute and annotation class FixedWe should revisit and rebase this PR after this is resolved.
- 🇳🇿New Zealand quietone
Attaching a patch that has conversions for the process plugins. It does not include work on the manager or the attribute class.
- Status changed to Postponed
10 months ago 3:51pm 4 March 2024 - Status changed to Needs review
9 months ago 3:39am 4 April 2024 - Status changed to Postponed
9 months ago 4:37am 4 April 2024 - Status changed to Closed: duplicate
9 months ago 1:55pm 5 April 2024 - Status changed to Needs review
9 months ago 4:19pm 5 April 2024 - Status changed to RTBC
9 months ago 6:38pm 5 April 2024 - 🇺🇸United States smustgrave
Seems all 78 instances of @MigrateProcessPlugin have been replaced.
- 🇳🇿New Zealand quietone
I am disappointed to see many of these changed to one-liners and I have noticed this on other issues as well. It seems reasonable to me to keep the style of the coding standard for annotations. And worse, for me, it makes these harder to scan. Since there is no coding standard specific for attributes I have created #3439004: Coding standard for attributes → .
I am disappointed to see many of these changed to one-liners and I have noticed this on other issues as well.
I received feedback to convert id-only attributes to one-liners on other issues for consistency, so I changed them similarly here. I agree that multi-line attributes with named properties is more readable, but people have made cases the other way. While I do have a preference, I don't feel that strongly about it, but putting coding standards in place is a reasonable next step.
- Status changed to Fixed
9 months ago 10:06am 6 April 2024 - 🇬🇧United Kingdom alexpott 🇪🇺🌍
Committed and pushed 8c0975a467 to 11.x and ee650b2e7f to 10.3.x. Thanks!
-
alexpott →
committed ee650b2e on 10.3.x
Issue #3421016 by quietone, godotislate: Convert MigrateProcessPlugin...
-
alexpott →
committed ee650b2e on 10.3.x
-
alexpott →
committed 8c0975a4 on 11.x
Issue #3421016 by quietone, godotislate: Convert MigrateProcessPlugin...
-
alexpott →
committed 8c0975a4 on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.