- Issue created by @larowlan
- First commit to issue fork.
- Merge request !6798Resolve #3421015 "Convert migratedestination plugin" → (Closed) created by godotislate
- Status changed to Needs review
10 months ago 12:30am 28 February 2024 Note that change to `core/modules/migrate/src/Plugin/MigratePluginManager.php` is also needed by other migrate plugins.
- Status changed to Needs work
10 months ago 2:53pm 28 February 2024 The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
10 months ago 3:09pm 28 February 2024 - 🇮🇳India mohit_aghera Rajkot
Note: BC approach to handle annotations and attributes in
MigratePluginManager
class is being evaluated in https://www.drupal.org/project/drupal/issues/3424509 📌 Update MigratePluginManager to include both attribute and annotation class FixedWe should revisit and rebase this PR after this is resolved.
- Status changed to RTBC
10 months ago 3:09pm 4 March 2024 - 🇺🇸United States smustgrave
Searched for @MigrateDestination and all 31 instances in core have been replaced.
Checked the attribute for the deriver class and no @Annotation.
Believe this one is good.
- Status changed to Postponed
10 months ago 3:44pm 4 March 2024 - Status changed to Needs review
9 months ago 11:48pm 3 April 2024 - Status changed to Postponed
9 months ago 4:39am 4 April 2024 - Status changed to Closed: duplicate
9 months ago 1:55pm 5 April 2024 - Status changed to Needs review
9 months ago 2:27pm 5 April 2024 Re-opening because the balance of destination plugins outside a couple done in 📌 Update MigratePluginManager to include both attribute and annotation class Fixed still need to be converted. MR here has been rebased and is ready for review.
- Status changed to Needs work
9 months ago 4:42pm 5 April 2024 - Status changed to Needs review
9 months ago 4:48pm 5 April 2024 Believe 2 were missed EntityFile and Book.php
Those two were already done in 📌 Update MigratePluginManager to include both attribute and annotation class Fixed
https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/file/...
https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/book/...- Status changed to RTBC
9 months ago 4:56pm 5 April 2024 - 🇺🇸United States smustgrave
You are correct, that's my mistake
Rebase my local and applying MR all instances of @MigrateDestination have been replaced.
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
Committed and pushed 38e722aa6f to 11.x and 3f64e2bf2c to 10.3.x. Thanks!
-
alexpott →
committed 3f64e2bf on 10.3.x
Issue #3421015 by godotislate: Convert MigrateDestination plugin...
-
alexpott →
committed 3f64e2bf on 10.3.x
- Status changed to Fixed
9 months ago 10:03am 6 April 2024 -
alexpott →
committed 38e722aa on 11.x
Issue #3421015 by godotislate: Convert MigrateDestination plugin...
-
alexpott →
committed 38e722aa on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.