- Issue created by @larowlan
- 🇦🇺Australia kim.pepper 🏄♂️🇦🇺Sydney, Australia
kim.pepper → made their first commit to this issue’s fork.
- Merge request !6621#3420991 Convert ImageToolkit plugin discovery to attributes → (Closed) created by kim.pepper
- Status changed to Needs review
12 months ago 10:57pm 15 February 2024 - Status changed to RTBC
12 months ago 12:46am 16 February 2024 - 🇦🇺Australia mstrelan
Looks great. I think it's fine to omit the param docs for id and title. All ImageToolkit plugins have been converted to use annotations.
- Status changed to Needs work
12 months ago 3:23am 16 February 2024 - 🇦🇺Australia mstrelan
As per @larowlan I think we need to add
public readonly ?string $deriver = NULLto the constructor params. - Status changed to Needs review
12 months ago 5:20am 16 February 2024 - Status changed to RTBC
12 months ago 7:57pm 17 February 2024 - 🇺🇸United States smustgrave
Appears all feedback has been addressed.
Did a search for @ImageToolkit and all 4 instances of core have been replaced.
- Status changed to Fixed
11 months ago 11:48pm 28 February 2024 - 🇬🇧United Kingdom alexpott 🇪🇺🌍
Committed and pushed ffaf987160 to 11.x and e8b4e5c252 to 10.3.x. Thanks!
Adding to 3395575
-
alexpott →
committed d332de97 on 10.3.x
Issue #3420991 follow-uo by alexpott: Convert ImageToolkit plugin...
-
alexpott →
committed d332de97 on 10.3.x
-
alexpott →
committed e8b4e5c2 on 10.3.x
Issue #3420991 by kim.pepper, larowlan, mstrelan: Convert ImageToolkit...
-
alexpott →
committed e8b4e5c2 on 10.3.x
-
alexpott →
committed bd5aa8ff on 11.x
Issue #3420991 follow-uo by alexpott: Convert ImageToolkit plugin...
-
alexpott →
committed bd5aa8ff on 11.x
-
alexpott →
committed ffaf9871 on 11.x
Issue #3420991 by kim.pepper, larowlan, mstrelan: Convert ImageToolkit...
-
alexpott →
committed ffaf9871 on 11.x
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
I committed a quick follow-up now that this, 📌 Convert ImageToolkitOperation plugin discovery to attributes Needs review and 📌 Convert ImageEffect plugin discovery to attributes RTBC are all in - in order to link the attributes together instead of pointing at the annotations. See https://git.drupalcode.org/project/drupal/-/commit/bd5aa8ffbe851e1a5104a...
Automatically closed - issue fixed for 2 weeks with no activity.
