- Issue created by @larowlan
- 🇦🇺Australia kim.pepper 🏄♂️🇦🇺Sydney, Australia
kim.pepper → made their first commit to this issue’s fork.
- Merge request !6623#3420992 Convert ImageToolkitOperation plugin discovery to attributes → (Closed) created by kim.pepper
- Status changed to Needs review
10 months ago 11:43pm 15 February 2024 - Status changed to Needs work
10 months ago 11:52pm 15 February 2024 - Status changed to Needs review
10 months ago 12:03am 16 February 2024 - Status changed to RTBC
10 months ago 12:31am 16 February 2024 - 🇦🇺Australia mstrelan
This looks great. All ImageToolkitOperation plugins have been converted to use attributes. I think it's better having all the docs, even if some like label seem self-explanatory.
- Status changed to Needs work
10 months ago 3:23am 16 February 2024 - 🇦🇺Australia mstrelan
As per @larowlan I think we need to add
public readonly ?string $deriver = NULLto the constructor params. - Status changed to Needs review
10 months ago 5:16am 16 February 2024 - Status changed to RTBC
10 months ago 3:53pm 16 February 2024 - 🇺🇸United States smustgrave
#8 appears to be addressed restoring RTBC status.
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
Committed and pushed 328bb474d7 to 11.x and 4eed1aa1dc to 10.3.x. Thanks!
Adding to https://www.drupal.org/node/3395575 →
-
alexpott →
committed 4eed1aa1 on 10.3.x
Issue #3420992 by kim.pepper, mstrelan, larowlan: Convert...
-
alexpott →
committed 4eed1aa1 on 10.3.x
- Status changed to Fixed
10 months ago 11:43pm 28 February 2024 -
alexpott →
committed 328bb474 on 11.x
Issue #3420992 by kim.pepper, mstrelan, larowlan: Convert...
-
alexpott →
committed 328bb474 on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.
