mb_convert_encoding is deprecated in PHP 8.2

Hi @dbielke1986 Is this a bug in the Caxy library related with.

php-htmldiff/lib/Caxy/HtmlDiff/Table
/TableDiff.php

To Fix the issue you can add the following code
instead
line 592
$htmlDiff = HtmlDiff::create(
mb_convert_encoding($oldContent, 'UTF-8', 'HTML-ENTITIES'),
mb_convert_encoding($newContent, 'UTF-8', 'HTML-ENTITIES'),
$this->config
);
to
$htmlDiff = HtmlDiff::create(
htmlspecialchars_decode($oldContent, ENT_QUOTES | ENT_HTML5),
htmlspecialchars_decode($newContent, ENT_QUOTES | ENT_HTML5),
$this->config
);

instead
line 630---
$dom->loadHTML(mb_convert_encoding(
$this->purifyHtml(mb_convert_encoding($text, $this->config->getEncoding(), mb_detect_encoding($text))),
'HTML-ENTITIES',
$this->config->getEncoding()
));

to

$dom->loadHTML(mb_convert_encoding(
$this->purifyHtml(mb_convert_encoding($text, $this->config->getEncoding(), mb_detect_encoding($text))),
'HTML-ENTITIES',
$this->config->getEncoding()
));

I think we need an MR for this issue before it should be "Needs review".
Can you push your changes to an MR?

Hi @dbielke1986 i you please review if this work i will create the MR

The issue is with php-htmldiff. The library needs the patch, and then the dependency revision needs to increase.

Just adding that there are now two PRS

• https://github.com/caxy/php-htmldiff/pull/129
• https://github.com/caxy/php-htmldiff/pull/125

As the issue is in a module dependency and not the module itself, we need to wait until library maintainers approve the PR. For now, I apply the patch with composer using the vendor folder as this:

 "vendor/caxy/php-htmldiff": {
                "TableDiff: Deprecated function mb_convert_encoding() in PHP 8.2 - [#123]" : "https://patch-diff.githubusercontent.com/raw/caxy/php-htmldiff/pull/125.patch"
            }

+1 for #10 comment

This is postponed on an upstream fix.

After patching as said in #10, I get error

iconv(): Detected an illegal character in input string in Caxy\HtmlDiff\Table\TableDiff->createDocumentWithHtml() (line 630 of /app/vendor/caxy/php-htmldiff/lib/Caxy/HtmlDiff/Table/TableDiff.php)

Adding //TRANSLIT solves issue for me.
Full line:

$dom->loadHTML(htmlspecialchars_decode(iconv('UTF-8', 'ISO-8859-1//TRANSLIT', htmlentities($text, ENT_COMPAT, 'UTF-8')), ENT_QUOTES));

https://github.com/caxy/php-htmldiff/releases/tag/v0.1.16 contains fixes for this and PHP 8.4 deprecations.

Can we get an update to the module to include the https://github.com/caxy/php-htmldiff/releases/tag/v0.1.16 version in the composer.json

Diff doesn't directly depend on caxy/php-htmldiff, it's a dependency of mkalkbrenner/php-htmldiff-advanced.

Thanks #14 //TRANSLIT helps me too.