- Issue created by @dbielke1986
- First commit to issue fork.
- 🇮🇳India himanshu_jhaloya Mandsaur
Hi @dbielke1986 Is this a bug in the Caxy library related with.
- Status changed to Needs review
4 months ago 2:53pm 21 February 2024 - 🇮🇳India himanshu_jhaloya Mandsaur
php-htmldiff/lib/Caxy/HtmlDiff/Table
/TableDiff.phpTo Fix the issue you can add the following code
instead
line 592
$htmlDiff = HtmlDiff::create(
mb_convert_encoding($oldContent, 'UTF-8', 'HTML-ENTITIES'),
mb_convert_encoding($newContent, 'UTF-8', 'HTML-ENTITIES'),
$this->config
);
to
$htmlDiff = HtmlDiff::create(
htmlspecialchars_decode($oldContent, ENT_QUOTES | ENT_HTML5),
htmlspecialchars_decode($newContent, ENT_QUOTES | ENT_HTML5),
$this->config
);instead
line 630---
$dom->loadHTML(mb_convert_encoding(
$this->purifyHtml(mb_convert_encoding($text, $this->config->getEncoding(), mb_detect_encoding($text))),
'HTML-ENTITIES',
$this->config->getEncoding()
));to
$dom->loadHTML(mb_convert_encoding(
$this->purifyHtml(mb_convert_encoding($text, $this->config->getEncoding(), mb_detect_encoding($text))),
'HTML-ENTITIES',
$this->config->getEncoding()
)); - Status changed to Needs work
4 months ago 12:28pm 26 February 2024 - 🇩🇪Germany dbielke1986
I think we need an MR for this issue before it should be "Needs review".
Can you push your changes to an MR? - 🇮🇳India himanshu_jhaloya Mandsaur
Hi @dbielke1986 i you please review if this work i will create the MR
- 🇺🇸United States bluegeek9
The issue is with php-htmldiff. The library needs the patch, and then the dependency revision needs to increase.
- Assigned to bluegeek9
- Status changed to Active
2 months ago 9:42pm 22 April 2024