The icon color for the 'Remove Media' button should match the button color.

I reviewed the issue and observed that the remove button has no close icon in other fields (for ex-media, and image fields ) except the media modal. There seems to be a lack of uniformity in design here, so we need to maintain the design consistency here either we should remove the close icon or add a close icon on the remove button globally on all the fields where the remove button exists.

Adding tag for maintainer feedback.

@saschaeggi please share your valuable feedback.

Thanks!

Fixed icon color issue for Remove Media button. Attaching screenshot for reference.

Getting 403 error.

Hi, @Nupur Badola
The 403 error that you're encountering I believe that its an issue with your setup and Nginx server configuration. Please check your Nginx error log to debug further.
Also @Tirupati_SIngh, I've tested your patch, though it solves the colour consistency issue and the close icon appearance, but the the point which was raised by @shweta__sharma has not been addressed, as I cannot see the close icon on normal image fields, as she already mentioned, it was only appearing on the Media modal!
It'll be great if we can achieve design consistency over here as well! Hence keeping it in NW state as of now.
I'm attaching before and after screen recordings for the same for easy reference!

@shweta_sharma,

the remove button has close icon is only available on Media modal

as the base theme of Gin in Claro and it is using the claro global styling library due to this the remove button has icon present on media modal only. This design inconsistency can also be found on Claro theme. To achieve the design consistency, the remove icon can be either removed or added globally for all the remove buttons available across the theme. I've fixed the color issue for the remove button for media modal as the issue has been raised for the button design only.

This design inconsistency is present for themes using Claro as the base theme. I've checked other themes whose base theme is other than Claro theme and the design inconsistency is not available for other themes. Attaching screenshots for reference.

Reviewed the MR. Not working for me.

Hello, @Tirupati_Singh,
Good observation! In that case I think its going beyond the scope of this issue ticket, and we can have a separate issue to address this!
As I've mentioned in my previous comment, apart from that, everything looks fine to me, hence moving it to RTBC++

Also, @Nupur Badola the issue is related to media and media library and can only be reproduce by adding media reference to a CT.
I see you're trying to test the same on normal image field, which is not pertaining to this issue, though its not clear to me what you tried to decipher through the video. If you find any issues with the image field and if it seems to be related to the base theme Claro and not restricted to Gin theme, then in my opinion it'd be better if we move that discussion by creating a new issue on Claro!