Call refreshVariables() where needed in various tests

Can MR be updated for 11.x

Yeah sure, thought this could be in 10.2 and 11.x as it's a bugfix.

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Silly bot.

Created second MR for the 11.x version

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Okay this bot is starting to annoy me

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Think it's getting confused as the ticket was 10.2.x but the latest MR was for 11.x

But reviewing 11.x and change seems good now.

unless there are any more objections: could we get this committed please? It's the last soft blocker for 📌 Implement the new access policy API Needs work , which I'm really hoping to land in 10.3

I'm triaging RTBC issues → . I read the IS, the comments and the comments. I didn't find any unanswered questions.

The Issue Summary is brief, it is not using the standard template. In particular, there isn't a proposed resolution which is one of the key things I look for. However, what is there does explain what is being done here, it is just in an unexpected place.

Both the issue summary and the last comment lead me to think that this should be a child issue of 📌 Implement the new access policy API Needs work . I skimmed through that issue and found in comment #47 that three issue were created to fix low hanging fruit. Based on that I am going to make this a child as I suggested as well as the other two so their connection is maintained.

Leaving at RTBC.

Committed/pushed to 11.x and cherry-picked to 10.3.x and 10.2.x, thanks!

quietone → closed merge request !6336

quietone → closed merge request !6368

Automatically closed - issue fixed for 2 weeks with no activity.