Contrib.social

Fix typehint mistake in new Access Policy API

Open on Drupal.org →
Created on 27 January 2024, 5 months ago
Updated 26 February 2024, 4 months ago

Problem/Motivation

When 📌 Add the access policy API RTBC landed, we added this piece of code to the base class:

  /**
   * {@inheritdoc}
   */
  public function calculatePermissions(AccountInterface $account, string $scope): CalculatedPermissionsInterface {
    return (new RefinableCalculatedPermissions())->addCacheContexts($this->getPersistentCacheContexts());
  }

That typehint is technically correct because RefinableCalculatedPermissions implements RefinableCalculatedPermissionsInterface, which in turn extends CalculatedPermissionsInterface. But phpstan throws a hissy fit on any extending code because methods of the refinable interface are being called even though we only typehint for the interface with fewer methods.

Proposed resolution

Change the typehint to RefinableCalculatedPermissionsInterface. We can do this without worry as the API hasn't been released yet. So as long as we commit this before 10.3 goes live, we are good.

📌 Task
Status

Fixed

Version

11.0 🔥

Component
Base  →

Last updated 12 minutes ago

Created by

🇧🇪Belgium kristiaanvandeneynde Antwerp, Belgium

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024