Add support for tagged_iterator to YamlFileLoader

Copied most of the code from \Symfony\Component\DependencyInjection\Loader\YamlFileLoader::resolveServices()

Looks like we need to add support to \Drupal\Component\Serialization\YamlPecl::decode() too 😒

We need to add a callback to \Drupal\Component\Serialization\YamlPecl::decode() to process the tag to make it work the same way for PECL Yaml. And we'll need to add a tests to \Drupal\Tests\Component\Serialization\YamlPeclTest and \Drupal\Tests\Component\Serialization\YamlTest to ensure Symfony and PECL work the same.

Let's expand the scope of 📌 Support Yaml::PARSE_CUSTOM_TAGS in \Drupal\Component\Serial::decodeization\YamlSymfony:: Needs work to do that?

Related issue: 📌 Always use YamlSymfony for loading service yaml files Needs review

Postponed on:

• 📌 Always use YamlSymfony for loading service yaml files Needs review
• 📌 Support Yaml::PARSE_CUSTOM_TAGS in \Drupal\Component\Serial::decodeization\YamlSymfony:: Needs work

All blockers are in

AFAICT all this still needs is test coverage + a change record?

This is just reusing Symfony code so not sure what tests we should add. Might be better just to start using it for real?

Opened MR!6980 to show how this could be used to simplify ThemeNegotiator; we can use it to replace many things that use the service_collector tag.

@kim.pepper think also this might need additional support in OptimizedPhpArrayDumper so the iterators are dumped and restored properly?

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

#15 @longwave I could be missing something, but I believe we did that already in 📌 Support IteratorArgument in \Drupal\Component\DependencyInjection\Dumper\OptimizedPhpArrayDumper::dumpValue RTBC

@kim.pepper see #3432595-9: Use a tagged service iterator for uninstall validators instead of individual lazy proxies → - I discovered there they are dumped correctly but restored as arrays of services instead of iterators which means they are no longer lazy - all services are instantiated when the service they are being injected into is instantiated.

I copied the relevant code block from \Symfony\Component\DependencyInjection\Dumper\YamlDumper::dumpValue() but not sure exactly what else I need to do.

Symfony's YamlDumper is not compatible with our OptimizedPhpArrayDumper. Instead we should copy some of the changes from 📌 Use a tagged service iterator for uninstall validators instead of individual lazy proxies Needs review over here.

Ported the code from 📌 Use a tagged service iterator for uninstall validators instead of individual lazy proxies Needs review and added additional test coverage to both YamlFileLoaderTest and ContainerTest.

Added CR: https://www.drupal.org/node/3436859 →

This looks great. Looking forward to not having to maintain our lazy service thing :)

alexpott → changed the visibility of the branch 3414208-theme-negotiator-test to hidden.

Committed/pushed to 11.x, thanks!

This doesn't cherry-pick cleanly to 10.3.x, but I think it makes sense to backport if we can for parity?

Published the CR

Rebased with git rebase --onto origin/10.3.x origin/11.x, fixed conflict in ContainerTest, and opened MR!7272 against 10.3.x.

rebase onto 10.3 looks great

Committed/pushed to 10.3.x, thanks!

Automatically closed - issue fixed for 2 weeks with no activity.

kim.pepper → closed merge request !6134