Remove 'pattern' description from hook_theme

I have removed the pattern from the doc comment and added an MR.Please review.

Removal wasn't complete

@shalini_jha, thanks for working on this! You've just missed removing the rest of the description for 'pattern'. So, right now the there is an incomplete sentence in the documentation. The full text that should be removed is in the Issue Summary. Cheers.

I have updated the MR, please review it.
Thanks

Seems to be adding code changes.

HI @smustgrave
I have removed description for 'pattern' only . and the other things are same ,
can you please describe more to work on this .
Thanks

@shalini_jha, this is getting closer. However, the example for 'pattern' also needs to be removed.

I've updated the issue summary to clarify that the entire description for 'pattern' is to be removed and that includes the example.

Thanks @quietone
I have updated the Mr according to your comment , please review.

That change seems good. Thanks.

I see that some of the confusions, at least on my part, is that 📌 Remove usage of forum module from comments and strings Fixed changed the text for 'pattern'.

I tried to commit this today but am getting an error when running commit-code-check.sh

Running PHPStan on changed files.

 [ERROR] No files found to analyse.                                                                                     


PHPStan: failed

I realise I chatted with @quietone about this when it came up in the book comment removal, but I think this in fact is not dead code.

See drupal_find_theme_templates it defaults to __ but in theory it can use anything specified in the info hook.

I think we should revise the text as follows or similar:

 *   - pattern: A regular expression pattern to be used to allow this theme
 *     implementation to have a dynamic name. The default is to use __ to
 *     differentiate the dynamic portion of the theme. Implementations
 *     can specify a different pattern if required.

HI , i have updated the text , please review.
Thanks

Update vs removal is done.

Committed to 11.x, needs re-roll to apply to 10.2.x

Thanks

larowlan → closed merge request !6114

HI @larowlan
Added a new Mr Against 10.2.x, please review.
Thanks

Reroll seems fine. That code block was removed as part of the forum deprecation.

Before setting issues to RTBC the title should be verified. We now have in the git log a commit message of "Remove 'pattern' description from hook_theme' which is absolutely wrong. This will cause unnecessary work for future people searching git history.

Checking the title is step 2 of Triage the Drupal core RTBC queue →

Removing title tag as title updated.

shalini_jha → closed merge request !8842