Run and correct PHPCS issues

Anjali Mehta → made their first commit to this issue’s fork.

It looks like the default branch on the fork is 8.x-1.x so the tests didn't run.

I had to update GitLab to use the correct default branch, so this MR needs to be redone against 2.0.x.

I created the 3411259-branch-2-0-x branch in the issue fork for a MR against the 2.0.x branch.

The MR I created is not complete.

The issue summary should always describe what the issue is trying to fix and, in the case, of coding standards issues, report which command has been used, which arguments have been used, and which report that command shown.

There is no report because that will be provided by the testing infrastructure, once PHP_CodeSniffer is enabled as described in the issue summary.

Notice that MR!63 is not complete.

Updating IS

See the issue summary of this issue, which was created by the project owner.

Using the new testing infrastructure, remove SKIP_PHPCS: '1' and then fix reported issues.

That value is contained in the .gitlab-ci.yml file.

variables:
  SKIP_ESLINT: '1'
  SKIP_PHPCS: '1'
  SKIP_PHPSTAN: '1'

Once the pipeline 79273 has been completed, its report will show which warnings/errors needs to be fixed.

The report is available on https://git.drupalcode.org/issue/domain-3411259/-/jobs/655776 (line 32 to line 1147).

I see, got it.

Thanks @apaderno, can you please add link to the report to IS?

tobiasb → changed the visibility of the branch 3411259-run-and-correct to hidden.

tobiasb → changed the visibility of the branch 3411259-skip-phpcs-0 to hidden.

fyi: I added a custom phpcs.xml to extends the lineLimit to 120.

Thanks, I left feedback in the MR, please check.

I added your suggested changes, but only those which does not increase the scope of the issue.

This issue was fixed in 📌 Configure and fix Eslint issues Fixed