- Issue created by @quietone
- First commit to issue fork.
- Status changed to Needs review
12 months ago 8:42am 22 December 2023 - Status changed to Needs work
12 months ago 4:55pm 22 December 2023 - ๐บ๐ธUnited States smustgrave
This is deleting the whole module. Not desired at all.
- ๐ณ๐ฟNew Zealand quietone
@arisen, this is only to remove usages of the book module from the Umami profile. Using grep the files that need to move can be found.
$ grep -ri book core/profiles/demo_umami/ | awk -F: '{print $1}' | sort -u | nl 1 core/profiles/demo_umami/themes/umami/css/classy/components/book-navigation.css 2 core/profiles/demo_umami/themes/umami/templates/classy/content/book-node-export-html.html.twig 3 core/profiles/demo_umami/themes/umami/templates/classy/layout/book-export-html.html.twig 4 core/profiles/demo_umami/themes/umami/templates/classy/navigation/book-all-books-block.html.twig 5 core/profiles/demo_umami/themes/umami/templates/classy/navigation/book-navigation.html.twig 6 core/profiles/demo_umami/themes/umami/templates/classy/navigation/book-tree.html.twig 7 core/profiles/demo_umami/themes/umami/templates/content/node.html.twig 8 core/profiles/demo_umami/themes/umami/umami.libraries.yml
- Status changed to Active
11 months ago 6:03am 11 January 2024 - ๐ณ๐ฟNew Zealand quietone
I rebased and reverted the module removal. This is ready for a fresh start.
- First commit to issue fork.
- Assigned to kostyashupenko
- ๐ท๐บRussia kostyashupenko Omsk
Gonna remove book from umami profile and from themes.
- Issue was unassigned.
- Status changed to Needs review
11 months ago 8:57am 17 January 2024 - Status changed to Needs work
11 months ago 2:06pm 17 January 2024 - Status changed to Needs review
11 months ago 8:45am 18 January 2024 - ๐ณ๐ฟNew Zealand quietone
cspell was not running. All I did was rebase.
- Status changed to Needs work
11 months ago 9:57am 18 January 2024 - Assigned to kostyashupenko
- ๐ท๐บRussia kostyashupenko Omsk
Trying to get more backend skills. Let me try to handle it
- Issue was unassigned.
- ๐ท๐บRussia kostyashupenko Omsk
pushed something. Cspell failure appeared after rebase, not sure how to fix it
- ๐ฆ๐บAustralia larowlan ๐ฆ๐บ๐.au GMT+10
Need to push to 11.x in the fork
- Status changed to Needs review
11 months ago 7:43am 19 January 2024 - ๐ฎ๐ณIndia djsagar
Hi All,
MR !5930 applied susses fully and book module from demo umami profile and from all core.
For reference:-
After MR !5930 code diff
After MR !5930 files
- Status changed to RTBC
11 months ago 2:14pm 19 January 2024 - ๐บ๐ธUnited States smustgrave
FYI @djsagar we don't need screenshots of the patch applying, thats evident with the MR applying.
Approach is the same we took for tour and forum so looks good to me.
- Status changed to Needs work
11 months ago 2:29pm 19 January 2024 - ๐บ๐ธUnited States smustgrave
@catch theyโre attached to the twig templates
- Status changed to RTBC
11 months ago 3:07pm 19 January 2024 - ๐ฌ๐งUnited Kingdom catch
- Status changed to Needs work
11 months ago 11:54am 23 January 2024 - Status changed to Postponed
10 months ago 10:37am 20 February 2024 - Status changed to Closed: duplicate
9 months ago 12:47am 28 February 2024 - ๐ณ๐ฟNew Zealand quietone
This is being for in the ๐ Remove Book module Postponed . I am closing as a duplicate and moving credit.