Save term lineage Drupal 10

Using also above patch, my composer.json file for SHS looks like this:

            "drupal/shs": {
                "#2712115: Add functionality to add new terms": "https://www.drupal.org/files/issues/2022-11-12/shs-add-new-term-functionality-2712115-66.patch",
                "#2712115: SHS & select2 integration": "https://www.drupal.org/files/issues/2023-10-02/shs-select2_integration-3101263-12.patch",
                "#2943357: Save term lineage": "https://www.drupal.org/files/issues/2023-12-20/save_term_lineage-2943357.patch"
            },

Hi, This is tested and ready. Greetings,

This is not working for me. Term lineage is not saved after applying the patches above.

The maintainer of this module said repeatedly this module will NEVER save term lineage as a feature.

I will suggest using https://www.drupal.org/project/taxonomy_set_lineage → together with shs to save the lineage.

Hi, great this solution is working for you.
For me because I had allready nodes with the lineage in drupal 6..7..it didn't work.
Now with both patches I can add new terms on node-edit page, and the term lineage is saved!
May be the term lineage could be placed in a submodule?
greetings, Martijn

Putting it in a submodule will be an excellent idea but I am not sure the maintainer will commit the patch. A better way will be to make a separate dependent module for it.

Hi, That would be awesome also!

If this is put into a sub module it would be more likely to be accepted, that way if it fails to work people can simply uninstall it.

Ok so three patches as mentioned by @Summit

Patch from
📌 Add functionality to add new terms Needs review
Patch from:
✨ SHS & select2 integration Needs work
Patch from:
📌 Save term lineage Fixed

• https://www.drupal.org/files/issues/2023-12-20/save_term_lineage-2943357... →
• https://www.drupal.org/files/issues/2022-11-12/shs-add-new-term-function... →
• https://www.drupal.org/files/issues/2023-10-02/shs-select2_integration-3... →

I'm not sure if it is a regression from this change, but even though I don't have Allow creating new items selected, all of my SHS widgets display an Add new term option.

It was introduced w/ 2.0.0-rc5. RC4 is not impacted.

With this change, when I try to delete a field or import config, I get this error:

The "entity_reference_shs" plugin does not exist.

I do not see this problem when I am running the previous commit of shs.

ok, reverting changes from 2.0.0-rc5

new release 2.0.0-rc7

https://www.drupal.org/project/shs/releases/2.0.0-rc7 →

ok so no , not fixed

so ya, this "new" is "new"

ok, tagging 2.0.0-rc8 with the exact same commit as 2.0.0-rc4

the "new term" functionality can stay parked in dev and the previous tags for now
Perhaps should be forked over to a 3.0.x branch instead and reset the 2.0.x branch back to 2.0.0-rc4

rc8 is now exactly the same as rc4
https://www.drupal.org/project/shs/releases/2.0.0-rc8 →

creating a new branch for the new term functionality.

Reverted all the new functionality from 2.0.0-rc5 through 2.0.0-rc7

Reverted this also from 2.0.x

Added new branch, pushed all the new stuff into the new branch 3.0.x

Here is the bugfix release for 2.0.0, it is rc9

https://www.drupal.org/project/shs/releases/2.0.0-rc9 →

Removed from 2.0.x and not included in 2.0.0-rc9

Added to 3.0.x included in 3.0.0-alpha1

it is in 3.0.0-alpha1, but since there's already reported issues, setting this back to active.

@hedn

Thanks for reporting, I've ripped this out of 2.0.x and put it into 3.0.0-alpha2

I've created a followup bug issue with your feedback added.

🐛 check term permissions to ensure that the add new term ui only shows up for those with those permissions Active

Hi, thanks for your renewed effort. I have it working using the patch I brought in. And it is only working when the Save New term option is triggered. I think putting this in a submodule is the best option, so people can choice to save new terms, or not.
I am not a programmer, but I can show screenshots of my site if needed? Greetings,

For some reason we don't see the "Save term lineage" setting on our field within "Manage form display". This happened when we were using 2.0.x-dev with the patches listed above and it is also happening now as we test the 3.0.0-alpha version.

Has anyone else run into this issue?

Hi,

I my case it kicks in without a setting. The vocabulary must allow adding new terms. I do not know exactly how my builder from Oekrain made it, but it is working.
Greetings,

@todea , I have published alpha3 , it would have the same problem that you reported. Please open a new issue, I've starred this project so I will see it and I will review any submitted patches.

@Summit, can you please uninstall your patched version and try 3.0.0-alpha3 and report your findings?

Hi,
it is working fine and connects new terms to nodes.
However I have 4 layers of terms: country , region, province, place

When I add this as one within this great module.
So I add

the country, the existing region, the existing province, the new place 

in one, And click save
The result is a nicely one line country-region-province-new place interconnected
But when I look further and want to show the result as terms-lineage it only shows the deepest term.
Somehow using only one line the terms are not all exactly interconnected

When I add this as separate terms

the country
the country and region 
the country and region and province
the country and region and province and new place

So I type in 4 records. And click save
The result is a nicely one line country-region-province-new place interconnected
when I then look further the result is correctly the term-lineage and shown as term-lineage like country > region > province > place.

Can the patch be altered as such that only one line of input is necessary for this;
the country, the existing region, the existing province, the new place and still it gives the correct interconnection?

Thanks for integrating these patches, greetings,

@summit, I specifically asked to test 3.0.0-alpha3 as this has the requested changes that you wanted. 2.0.x does not have these changes.

I will set up a testsite to test this. Thanks for building this 3 branch! greetings,

Hi Joseph,

I set up a testsite with version 3.00.alpha3. It works as the patch, so https://www.drupal.org/project/shs/issues/3409930#comment-15848470 💬 Save term lineage Drupal 10 Active is still valid.

I only see somehow two issues:
- The newly added term is not shown in the new box, only when I click in the box I see my newly add term "Weibersbrunn (A place in the area aschaffenburg, in the province Beieren in the country Germany :) See attached image
https://www.drupal.org/files/issues/2024-11-08/fill-in-new%20place.jpg →
- Somehow a second new term-add term, is placed at the end of the working new term-add term. I do not know if this is design on my part, I do not think so, because the patch itself doesn't show this? See attached images.
https://www.drupal.org/files/issues/2024-11-08/filled%20in%20new%20place... →
https://www.drupal.org/files/issues/2024-11-08/empty%20code%20new%20term... →

Greetings,