- Issue created by @deepakkm
- ๐ฎ๐ณIndia prashant.c Dharamshala
Prashant.c โ made their first commit to this issueโs fork.
- Status changed to Needs review
about 1 year ago 10:52am 12 December 2023 - ๐ฎ๐ณIndia prashant.c Dharamshala
Incorporated a .gitlab-ci.yml file into the project's root directory by utilizing the Drupal Association's template.gitlab-ci.yml contents. Continuously learning about it as I progress.
Thanks
- ๐ฎ๐ณIndia vipin.mittal18 Greater Noida
vipin.mittal18 โ made their first commit to this issueโs fork.
- Merge request !49Issue #3340957 by Ewout Goosmann, ankitv18, DamienMcKenna, Kulturmensch:... โ (Open) created by vipin.mittal18
- Open on Drupal.org โCore: 10.2.x + Environment: PHP 8.2 & MySQL 8last update
10 months ago Not currently mergeable. - last update
10 months ago 62 pass - Status changed to Needs work
8 months ago 3:40pm 19 April 2024 - ๐ฏ๐ตJapan ptmkenny
@Prashant.c Thanks for adding this.
@vipin.mittal18 It looks like you fixed some coding standards and PHPStan issues. However, I think that is out of scope for this MR. This is specifically about adding GitLab CI, not fixing the problems identified by GitLab CI, which should be separate issues.
Adding the CI template is very easy if that is the only file in the commit to review.
- ๐ฎ๐ณIndia vipin.mittal18 Greater Noida
Hello @ptmkenny, I have modified gitlabci.yml file only. Refer https://git.drupalcode.org/project/schema_metatag/-/merge_requests/49/di.... Coding standards are previously committed by someone.
- ๐ฏ๐ตJapan ptmkenny
There are still irrelevant changes not related to the GitLab CI template.
Also, it seems that the comments have been stripped from the latest version of the template (https://git.drupalcode.org/project/gitlab_templates/-/blob/main/gitlab-c...), but I think the comments provide useful information.
- last update
7 months ago 62 pass - First commit to issue fork.
- last update
7 months ago 62 pass - Merge request !55Issue #3340957 by Ewout Goosmann, ankitv18, DamienMcKenna, Kulturmensch:... โ (Merged) created by ankitv18
- Open on Drupal.org โCore: 10.2.x + Environment: PHP 8.2 & MySQL 8last update
7 months ago Not currently mergeable. - last update
7 months ago 62 pass - last update
7 months ago 62 pass - last update
7 months ago 62 pass - last update
7 months ago 62 pass - last update
7 months ago 62 pass - Status changed to Needs review
7 months ago 5:29pm 14 May 2024 - ๐ฎ๐ณIndia ankitv18
I've raised MR!55 against 3.0.x-dev branch please review and merge this one if possible.
- last update
7 months ago 62 pass - Status changed to RTBC
7 months ago 9:46am 15 May 2024 - last update
7 months ago 62 pass - last update
7 months ago 62 pass - Status changed to Needs work
7 months ago 12:10pm 15 May 2024 - ๐ฏ๐ตJapan ptmkenny
This needs work.
@poorva If you mark RTBC, you need to state why.
- ๐ฎ๐ณIndia ankitv18
Hi @ptmkenny,
Can you please review MR!55: https://git.drupalcode.org/project/schema_metatag/-/merge_requests/55/diffs and if it possible can you merge this one? - ๐ฏ๐ตJapan ptmkenny
@ankitv18 Ok, I reviewed MR55. This looks better since it adds the template and leaves the tests as a separate issue, but I think the links to the documentation should be restored.
- last update
7 months ago 62 pass - ๐ฎ๐ณIndia ankitv18
@ptmkenny I've updated the MR!55 https://git.drupalcode.org/project/schema_metatag/-/merge_requests/55/diffs , please review and check whether this one can be merged to 3.0.x-dev
- Status changed to Needs review
7 months ago 5:59am 17 May 2024 - last update
7 months ago 62 pass - First commit to issue fork.
- last update
7 months ago 62 pass - Status changed to Needs work
7 months ago 4:26pm 21 May 2024 - ๐ฏ๐ตJapan ptmkenny
@Rajeshreeputra Your addition of the previous major test needs additional configuration since this module requires PHP 8.
- last update
7 months ago 62 pass - Status changed to Needs review
6 months ago 1:07pm 13 June 2024 - ๐ฎ๐ณIndia ankitv18
ankitv18 โ changed the visibility of the branch 3408108-add-gitlab-ci to hidden.
- Status changed to RTBC
6 months ago 1:46pm 13 June 2024 -
DamienMcKenna โ
committed f360dedf on 3.0.x authored by
ankitv18 โ
Issue #3408108 by ankitv18, vipin.mittal18, Rajeshreeputra, Prashant.c,...
-
DamienMcKenna โ
committed f360dedf on 3.0.x authored by
ankitv18 โ
- Status changed to Fixed
6 months ago 2:52pm 13 June 2024 Automatically closed - issue fixed for 2 weeks with no activity.