- Issue created by @Anybody
- 🇮🇳India ravi kant Jaipur
@Anybody
I try to find issue. Is this issue with default setup. I am looking on default setup of Drupal 10.2.0.
Please provide screenshot also. - Status changed to Postponed: needs info
11 months ago 8:58am 12 January 2024 - 🇨🇭Switzerland saschaeggi Zurich
@Anybody seems like a good candidate to move to Core as we can change the default for this in Claro. (it's not defined by Gin).
Would you mind either moving this issue or creating a new one in the core issue queue?
- 🇩🇪Germany Anybody Porta Westfalica
Thanks @saschaeggi! I agree! Moved to Drupal Core - Claro theme!
Fixing this, it might also make sense to take a general look at the default table styling (align, border, ... ) to fit the general Claro look.
- Status changed to Active
11 months ago 12:03pm 12 January 2024 - First commit to issue fork.
- Merge request !9879#3405277: Add vertical-align: top as default for table cells → (Closed) created by scott_euser
- 🇬🇧United Kingdom scott_euser
Created an MR (probably my CSS is wrong, I don't do front-end much so I haven't set up linter to match core).
Before and after added to issue summary. The issue becomes obvious when cell contents are vastly different from each other like in this example.
- 🇬🇧United Kingdom scott_euser
Okay figured out how to run the linter, sorry for noise. Anyways ready for review.
- 🇫🇷France nod_ Lille
Committed and pushed a11036104f to 11.x and a3941f583e to 11.1.x. Thanks!
- 🇩🇰Denmark ressa Copenhagen
I understand the thought behind this change, but it has unintended consequences all over the place, as I see it ... For example in the Token module modal, but also in Views, where the lines now are not aligned beautifully, but pushed at the top up in tables and the Views UI.
Also, why do we need to update the
th
in the first place?Drupal 11 - A Views table and Views interface adding a field
Table, before and after
Views UI -- adding a field, before and after
Token module is also affected
See also this MP4 file: overlap.mp4 →
I think this needs to be rolled back, and given some more thought ...
- 🇩🇪Germany Anybody Porta Westfalica
Thanks for the feedback @ressa and sorry I didn't see that before!
Now the question is, are there any better ideas or CSS options to improve this?
I think we'll need to discuss this again in general... mhm, sad. - 🇬🇧United Kingdom scott_euser
Wonder if we can make it a configuration option in Views table display plugin? So opt-in?
- 🇫🇷France nod_ Lille
we can fix the uis where this makes sense, like the cell for tabledrag, the translation table, etc. not a by defa,ult thing
- 🇩🇰Denmark ressa Copenhagen
No problem @anybody, it's only natural that sometimes some things happen elsewhere, when you improve Drupal :)
And thanks for a fast reversion @nod_.Maybe the title could be updated, and refined afterwards? (I also thought about "Allow table cell content to stay at the top, as tall cells on same row").
please correct me if i am on wrong direction as far i understood to fix the alignment how about using padding or transparent border to align it in middle.
please correct me if i am on wrong direction as far i understood to fix the alignment how about using padding or transparent border to align it in middle.