Contrib.social

Add vertical-align: top as default for table cells

Open on Drupal.org →
Created on 30 November 2023, 11 months ago
Updated 12 January 2024, 9 months ago

Problem/Motivation

Especially in the administration area, large tables can appear. This may also mean that table cells have several lines in some rows.

Currently, Gin middle-valigns table cell contents, which makes such tables hard to read.

Steps to reproduce

Open an administration page which shows a table, for example created by theme_table:

[
      '#theme' => 'table',
      '#header' => $header,
      '#rows' => $rows,
      '#empty' => $empty,
      [...]
];

with large contents in at least one cell. It's hard to read.

Proposed resolution

Set

td, th {
  vertical-align: top;
}

by default in Gin, as it's an Admin Theme, which should be able to handle such administrative UI elements like tables as good as possible.

Remaining tasks

- Discuss
- Implement
- Find possible conflicts (Views?)
- Test
- Release

User interface changes

Table contents are vertical-aligned top by default in Gin

API changes

None

Data model changes

None

✨ Feature request
Status

Active

Version

11.0 🔥

Component
Claro  →

Last updated 23 minutes ago

Created by

🇩🇪Germany Anybody Porta Westfalica

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @Anybody
  • Comment 9 months ago →
    🇮🇳India ravi kant Jaipur

    @Anybody
    I try to find issue. Is this issue with default setup. I am looking on default setup of Drupal 10.2.0.
    Please provide screenshot also.

  • Status changed to Postponed: needs info 9 months ago
  • Comment 9 months ago →
    🇨🇭Switzerland saschaeggi Zurich

    @Anybody seems like a good candidate to move to Core as we can change the default for this in Claro. (it's not defined by Gin).

    Would you mind either moving this issue or creating a new one in the core issue queue?

  • Comment 9 months ago →
    🇩🇪Germany Anybody Porta Westfalica

    Thanks @saschaeggi! I agree! Moved to Drupal Core - Claro theme!

    Fixing this, it might also make sense to take a general look at the default table styling (align, border, ... ) to fit the general Claro look.

  • Status changed to Active 9 months ago
  • Comment 9 months ago →
    🇩🇪Germany Anybody Porta Westfalica
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024