Unable to generate canonical, edit, and update URLs for entity test multilanguage with bundle

Fixes are done, please review the MR.

In the gitlab CI build, the test-only step does not fail because this is a correction in one of the modules used for testing, So I've attached a screenshot of what happens when fixes are not one.

Confirmed I got the same failures as #3 locally.

Seems to be fixing a test stuff only and didn't break anything.

Thanks for finding this and making an MR!

I think we need a title here that better reflects what is being fixed. Maybe 'Correct links for entity_test_mul_with_bundle'?

Also, this should have some review of the history to be sure that this is not an intended error in a test entity. A check should be done to see if anyone commented about the links in the issue. But more importantly is to check any testing done in that issue that may be using these links. The entity was added at #2571235-59: [regression] Roles should depend on objects that are building the granted permissions → .

I am moving to the same component as the originating issue.

Thanks for the feedback!

I've fixed the title to explain what the exact problem is, and what the issue fixes. Let me know if it needs more explanation.

The entity class commit history is this:
- Class creation https://git.drupalcode.org/project/drupal/-/commit/cffb02aad63664e7930a3... . Issue related: https://www.drupal.org/project/drupal/issues/2571235 →
- Adding declare(strict_types=1): https://git.drupalcode.org/project/drupal/-/commit/489c3286ce9c4893fe824... . Issue related: https://www.drupal.org/project/drupal/issues/3400334 📌 Add declare(strict_types=1) to all test modules Postponed

This entity is only used at core to check the content translation permissions: https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/conte... . No URLs are used.

Conclusions:

• The entity type has been created to test roles dependencies. More information: https://www.drupal.org/project/drupal/issues/2571235 →
• The entity URL of this specific entity type is not used in core tests.
• As the objective of the test was checking permissions, this might have been accidental.

Can you review again? Thanks!

Fixing the status.

@omarlopesino excellent detail!

I'm actually on the fence if we even want the new test in core. It's pretty clear there was a mistake in the entity type annotation and link generation should already be well covered. I'd treat the test as a test-only thing for us to verify that everything is now fixed and leave it out when committing this.

Still RTBC and approved either way, just a note from a maintainer to a committer.

catch → closed merge request !5515

Agreed the test for the test module doesn't give us much here, this is very unlikely to regress once it's fixed.

Committed/pushed (minus the new test) to 11.x and cherry-picked back through to 10.3.x, thanks!

Wrong status..

Automatically closed - issue fixed for 2 weeks with no activity.