- Issue created by @dww
- First commit to issue fork.
- Status changed to Needs review
about 1 year ago 10:53pm 19 November 2023 - π¦πΊAustralia mstrelan
Expanded to include a few int and bool casts, there were not many.
Decided to exclude
\Drupal\KernelTests\AssertContentTrait
as I think it should have its own issue. - π¦πΊAustralia mstrelan
Have adjusted this to include incorrect type declarations and hard coded values (e.g.
FALSE
instead of0
). - Status changed to RTBC
about 1 year ago 1:14pm 20 November 2023 - πΊπΈUnited States smustgrave
44 files is a lot but was easy to read. Tests are all green but guess we will know quickly when strict gets added to all kernel tests.
- πΊπΈUnited States dww
Opened one other informational thread, but agreed this is ready.
Crediting mstrelan for the effort, smustgrave and myself for reviews.
Thanks!
-Derek - π³πΏNew Zealand quietone
I'm triaging RTBC issues β . I read the IS, the comments and reviewed the MR. I didn't find any unanswered questions, and all my questions were already answered.
Leaving at RTBC.
-
larowlan β
committed 5b8514ad on 11.x
Issue #3402295 by mstrelan, dww, smustgrave: Fix strict type errors in...
-
larowlan β
committed 5b8514ad on 11.x
-
larowlan β
committed ee348449 on 10.2.x
Issue #3402295 by mstrelan, dww, smustgrave: Fix strict type errors in...
-
larowlan β
committed ee348449 on 10.2.x
- Status changed to Fixed
12 months ago 10:01pm 7 January 2024 - π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
Committed to 11.x and backported to 10.2.x for consistency with other test strict-typing changes
Automatically closed - issue fixed for 2 weeks with no activity.