- Issue created by @longwave
- last update
about 1 year ago Build Successful - @longwave opened merge request.
- Status changed to Needs review
about 1 year ago 3:25pm 27 October 2023 - π¬π§United Kingdom longwave UK
This was easier than I thought. Not sure if π Use autowiring for core modules and services Needs work should go first or whether we should just commit this all in one go.
- Status changed to RTBC
about 1 year ago 4:27pm 27 October 2023 - πΊπΈUnited States smustgrave
Autowiring is so cool. Wise I understood the sorcery fully.
But change didn't break anything so seems good.
- Open on Drupal.org βEnvironment: PHP 8.2 & MySQL 8last update
about 1 year ago Not currently mergeable. - Open on Drupal.org βEnvironment: PHP 8.2 & MySQL 8last update
about 1 year ago Not currently mergeable. - Open on Drupal.org βEnvironment: PHP 8.2 & MySQL 8last update
about 1 year ago Not currently mergeable. - Open on Drupal.org βEnvironment: PHP 8.2 & MySQL 8last update
about 1 year ago Not currently mergeable. - Open on Drupal.org βEnvironment: PHP 8.2 & MySQL 8last update
about 1 year ago Not currently mergeable. - Open on Drupal.org βEnvironment: PHP 8.2 & MySQL 8last update
about 1 year ago Not currently mergeable. - Open on Drupal.org βEnvironment: PHP 8.2 & MySQL 8last update
about 1 year ago Not currently mergeable. - First commit to issue fork.
- π³π±Netherlands spokje
Not sure if #3295751: Autowire core services that do not require explicit configuration should go first or whether we should just commit this all in one go.
If we have 2 issues about that, let's at least not have duplicate changes in both of them.
Came for the reroll,, but now removed the changes from
core/core.services.yml
and its testing, since that already/also lives in π Use autowiring for core modules and services Needs work . - π³π±Netherlands spokje
And then stuff broke and
testCoreAutowiring
shows _way_ less services that could/should be auto-wired, because they have no alias. - Status changed to Postponed
about 1 year ago 10:59am 11 November 2023 - π¬π§United Kingdom longwave UK
Let's postpone this on the other one, it is smaller in scope and hence easier to get in, then this can be rerolled on top.
- Status changed to RTBC
about 1 year ago 11:01am 11 November 2023 - last update
about 1 year ago Build Successful 45:05 43:49 Running- Open on Drupal.org βEnvironment: PHP 8.2 & MySQL 8last update
about 1 year ago Not currently mergeable. - Status changed to Needs work
about 1 year ago 5:15pm 16 November 2023 The Needs Review Queue Bot β tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide β to find step-by-step guides for working with issues.
- Status changed to Postponed
about 1 year ago 5:22pm 16 November 2023