Use autowiring for core controllers

📌 Allow controller service wiring via constructor parameter attributes Fixed is in so setting to active

First pass at this.

Seems to have CC failures.

Nitin shrivastava → made their first commit to this issue’s fork.

Very neat.

Ran the test-only feature

There was 1 failure:
1) Drupal\KernelTests\Core\DependencyInjection\AutowireTest::testCoreControllerAutowiring
The following core controllers can be autowired. Remove the create() method:
\Drupal\views_ui\Controller\ViewsUIController
\Drupal\update\Controller\UpdateController
\Drupal\tracker\Controller\TrackerController
\Drupal\system\CronController
\Drupal\system\Controller\ThemeController
\Drupal\system\FileDownloadController
\Drupal\shortcut\Controller\ShortcutSetController
\Drupal\search\Controller\SearchController
\Drupal\menu_ui\Controller\MenuController
\Drupal\help\Controller\HelpTopicPluginController
\Drupal\dblog\Controller\DbLogController
\Drupal\contact\Controller\ContactController
\Drupal\config_translation\Controller\ConfigTranslationListController
\Drupal\comment\Controller\CommentController
\Drupal\ckeditor5\Controller\CKEditor5MediaController
\Drupal\book\Controller\BookController
\Drupal\block\Controller\BlockController
\Drupal\block\Controller\BlockListController
\Drupal\announcements_feed\Controller\AnnounceController
Failed asserting that an array is empty.

So check seems good. And deletions didn't break anything. Think we can rely on the tests on this one. Controllers pretty important in the existing tests :)

Committed to 11.x

Waiting on second opinion about whether this still qualifies for 10.2.x

Too late for 10.2.x now, marking as fixed in 11.x.

Automatically closed - issue fixed for 2 weeks with no activity.