- Issue created by @spokje
- last update
about 1 year ago Custom Commands Failed - @spokje opened merge request.
- last update
about 1 year ago 30,434 pass - @spokje opened merge request.
- last update
about 1 year ago 30,434 pass - last update
about 1 year ago 30,436 pass - last update
about 1 year ago 30,436 pass - Status changed to Needs review
about 1 year ago 8:40am 25 October 2023 - π³π±Netherlands spokje
The current MR contains no BC-stuff whatsoever, because of two reasons:
1. I want to seek blessing for the current approach before wandering into BC-land.
2. I genuinely have no clue if and how to approach this.Putting this to NR for 1 and guidance on 2.
- πΊπΈUnited States smustgrave
Not sure who can give that blessing, can ping them though?
- π¬π§United Kingdom longwave UK
We can't add the void return here, because that breaks BC for existing actions. I'm also wary about removing the parent interface because if something is relying on ExecutableInterface then suddenly that will start failing.
Can we just add this to ActionInterface while keeping ExecutableInterface satisfied?
public function execute($object = NULL);
- Status changed to Needs work
about 1 year ago 12:09am 16 November 2023