Duplicated required marks in field tabs with GIn admin theme

It seems the issue is in this file https://git.drupalcode.org/project/field_group/-/blob/1211c8f4e06592418c.... With this commit, we have switched from using .text() to .html() to build the content of the tabs. As a result, HTML tags, such as , are now included in the tab titles.

We are seeing this issue as well when using Horizontal Tabbed field groups on the Gin theme. Switch to vertical tabs or a different theme removes the issue.

I can confirm that using Gin with Field Group results in gin's tabs.css file being loaded in the front end (due to the Gin admin menu, I assume) and messing up many (all?) of Field Group's horizontal tab styles. 🙁

-mike

Thanks for the patch. I confirm that patch #6 fixes the issue. Tested on Drupal 10.3.0.

I can also confirm that the patch fixes the issue for 3.6 and Drupal 10.3.0.

I can confirm the patch works on 10.3.1 with Gin admin theme 8.x-3.0-rc13 and field group on 8.x-3.6

I can also confirm that the patch fixes the issue for 3.6 with Drupal 10.2.6.

Confirming patch in #6 fixed this issue (8.x-3.6, Drupal 10.2.7, Gin 8.x-3.0-rc13)

Patch #6 worked for me on Field Group 8.x-3.6, Drupal 10.3.3, Gin 3.0.0-rc13.

Please use MRs!

Merging based on the many RTBC's.

This introduced a regression. Created a follow-up issue here: 🐛 Horizontal Tabs render broken, if child allows HTML Active .

Automatically closed - issue fixed for 2 weeks with no activity.

Would it be a good idea to commit this on the stable 3.x branch as well?

@pfrenssen I'm not against it. Still I think we should better focus on a stable 4.0.0 release!

Thanks, Andre, for the patch in #6!
It is working with the Field Group ~3.0 version.

Hoping this fix makes it into the 8.x-3.x branch, especially since Field Group 4.0.0-alpha1 has been released. Many sites are unlikely to upgrade from ~3 to ~4 until an RC or the stable 4.0.0 release is available.

For those of us on 3.6, I'm attaching a patch ported from 🐛 Horizontal Tabs render broken, if child allows HTML Active #15 🐛 Horizontal Tabs render broken, if child allows HTML Active , only the changes for formatters/tabs/horizontal-tabs.js.

Minimally tested on horizontal tabs, enabling "Mark group as required if it contains required fields." now works as expected: only one required mark, only shown on tab titles for panes actually containing required fields.

I also came across this issue with Gin 4.0.4 and Field Group 4.0.0-alpha1. The "Mark group as required if it contains required fields." checkbox option did not make any difference. I created this patch which gets around the issue and forces the required mark regardless of this option. There should be a better way to do this, but at least this patch would allow me to ensure that the horizontal tabs were always marked correctly (aka, I always want to mark the group required if there are required fields).