Deprecate ContextProvidersPass in favor of using service_id_collector

Not sure if I'm missing anything and the compiler pass is in fact needed, but just stumbled upon this and was a bit confused. Will open an MR, let's see if it's green.

Tests appear green.

Will need a CR.

Fair enough, although I wasn't sure what to write in the change notice, as I can't fathom any reason why someone would be using that.

Thanks!

Compiler passes are considered internal → , I don't think this warrants a change record as I also don't see how anyone else would be extending or reusing it, so I've deleted the change record.

Committed and pushed 0a13623646 to 11.x and d0b7905944 to 10.2.x. Thanks!

Awesome, thanks! Opened 📌 Remove deprecated ContextProvidersPass Active for the actual removal.

Automatically closed - issue fixed for 2 weeks with no activity.

This issue added a deprecation with a link to a change record that does not exist.

I added a draft change record so the docbloc can be updated. It is not complete so I am tagging for change record updates.

Took a stab at the change record - are there any situations in which someone might use that class elsewhere, extend it, or override it? I can't think how that would be useful let alone possible.

Also shouldn't the 11.x commit remove the class?

I was quite confused by #13, but then re-read the issue and this is what happened:

1. In #5 @smustgrave requested a CR after which I wrote one and updated the link in the code.
2. In #8 @longwave considered the CR unnecessary, thus deleted it, but committed the patch with the link
3. In #13 @quietone noticed the broken link and added a (draf) CR

So maybe you three need to hop on a call and discuss what does or does not warrant a CR ;-)
When there's consensus on whether or not one is needed, the link can either be dropped or updated. I don't feel strongly either way (as hinted at in #6 I could certainly live without one, but I don't really care).

Also Re #14:

1. I couldn't think of any legitimate reason why someone would extend the class either.
2. The 11.x branch (somewhat confusingly) is not yet opened for 11.x development, but always targets the next 10.x release (i.e. 10.3.x right now). I already opened 📌 Remove deprecated ContextProvidersPass Active which can be tackled once 11.x development actually starts.

As we need to link the deprecation somewhere we do need a change record, that was my mistake.

Opened a new MR with the change record link.

CR link seems good

Committed and pushed cc8a853306 to 11.x and ce3da88a84 to 10.2.x.

longwave → closed merge request !6272

longwave → closed merge request !5028

Automatically closed - issue fixed for 2 weeks with no activity.