- Issue created by @_renify_
- last update
about 1 year ago 29,483 pass - Status changed to Needs review
about 1 year ago 12:06pm 25 September 2023 - Status changed to Needs work
about 1 year ago 1:41pm 25 September 2023 - 🇺🇸United States smustgrave
Thank for reporting.
We will need a test to show this issue, but also may need to dig deeper. Typically these kind of issues putting an isset or !empty is masking an actual problem.
- 🇵🇭Philippines _renify_ cebu
There is error message encounter on 3389478-date-1.patch so i uploaded new patch.
- last update
12 months ago 29,672 pass - 🇧🇪Belgium dieterholvoet Brussels
I think adding those
empty()
calls is enough here, since the same check is being done in the child methodDrupal\views\Plugin\views\filter\Date::acceptExposedInput()
:if ($operators[$operator]['values'] == 1) { // When the operator is either <, <=, =, !=, >=, > or regular_expression // the input contains only one value. if ($this->value['value'] == '') { return FALSE; } } elseif ($operators[$operator]['values'] == 2) { // When the operator is either between or not between the input contains // two values. if (empty($this->value['min']) || empty($this->value['max'])) { return FALSE; } }
- 🇧🇪Belgium dieterholvoet Brussels
DieterHolvoet → changed the visibility of the branch 10.1.x to hidden.
- First commit to issue fork.
- First commit to issue fork.
- 🇮🇳India arunkumark Coimbatore
Updated issue summary as per issue summary document. →
- Status changed to Needs review
2 months ago 7:25am 16 August 2024 - 🇮🇳India arunkumark Coimbatore
Run the PHPUnit locally, Not getting any errors. But getting errors, but getting error git pipeline.
- Status changed to Needs work
about 2 months ago 12:24pm 20 August 2024 - 🇺🇸United States smustgrave
Previously tagged for tests so moving back for those
Did not review.
- 🇮🇳India arunkumark Coimbatore
arunkumark → changed the visibility of the branch 3389478-warning-undefined-array-11.x to hidden.
- 🇮🇳India arunkumark Coimbatore
arunkumark → changed the visibility of the branch 3389478-warning-undefined-array-11.x to active.
- 🇮🇳India arunkumark Coimbatore
arunkumark → changed the visibility of the branch 3389478-warning-undefined-array to hidden.
- Status changed to Needs review
about 2 months ago 8:16am 21 August 2024 - 🇮🇳India arunkumark Coimbatore
Added empty condition for date filter and test for MIN and MAX empty on date filter.
- Status changed to Needs work
about 1 month ago 8:53pm 5 September 2024 - 🇺🇸United States smustgrave
Believe the tests need some work as the test-only feature is passing when it should fail.
- Status changed to Needs review
about 1 month ago 3:37pm 9 September 2024 - 🇺🇸United States smustgrave
Test-only is still passing when it should be failing.
- 🇮🇳India arunkumark Coimbatore
@smustgrave
Verified the Failing jobs are irrelated to the changes. After syncing the latest 11.x branch the issue was resolved.