PHP 8.1 compatibility issues: passing null to strlen() and strpos() is deprecated

Thanks for reporting and working on this!

I checked the code and yes, the proposed patch will fix the deprecation messages, but it will not fix the root cause of this issue (a coding style bug). I suppose that the problem itself is here: https://git.drupalcode.org/project/advagg/-/blob/7.x-2.x/advagg.missing.... , where the $contents variable is defined only in the IF branch of that condition. Therefore it can be undefined (NULL). See:

      if (is_readable($file)) {
        ...
        $contents = advagg_load_css_stylesheet($file, $optimize, $aggregate_settings, $file_contents);
      }
      else {
        // File is not readable.
        $write_aggregate = advagg_missing_file_not_readable($file, $aggregate_filename, TRUE);
      }

      ...

      if ($media_changes) {
        $media_blocks = advagg_parse_media_blocks($contents);
        ...
      }

I propose that we fix the problem here - it could be sufficient to initialize the empty $contents variable in the else branch of the condition, or before the condition, or similar. Thanks!

Please review.

This still needs work. The merge request added the variable initialization after the opening IF. This would not help, because in the else branch it would still be undefined.

      else {
        // File is not readable.
        $write_aggregate = advagg_missing_file_not_readable($file, $aggregate_filename, TRUE);
      }

Also please do not remove the $contents = ''; after the advagg_parse_media_blocks() call, because it has different purpose (to cleanup the variable, which is being reused later). This has nothing to do with this problem.

         $media_blocks = advagg_parse_media_blocks($contents);
-        $contents = '';

Thanks!

Poker10, thank you for your notice.
I've put the check after if/else - it will catch null in case of 'else'-branch execution and also in case of smth wrong during 'if'-branch execution.

Added PHP5.4 compatibility

Thanks! Patch looks good, but unfortunatelly it does not apply.

Re-rolled patch against 7.x-2.36

@aquaphenix Which patch have you re-rolled? Your patch is not same as patch in #9 and brings back the PHP 5.6 incompatibility. Please pay attention while re-rolling patches, so that the latest patch is re-rolled.

Anyway, we have a open MR here: https://git.drupalcode.org/project/advagg/-/merge_requests/30 , so please let's just continue here. I am hiding all patches in this issue. We need to update the MR to match the patch #9 and then we can review this. Thanks!

Hi, resolved the MR to apply the patch #9. Please review, thanks.

I have added few comments to the MR. Thanks!

@poker addressed #16 🐛 PHP 8.1 compatibility issues: passing null to strlen() and strpos() is deprecated Needs work

I have done small fixes in the MR, otherwise I think this looks good.

Thanks all, committed and pushed this!

Automatically closed - issue fixed for 2 weeks with no activity.