- Issue created by @Grevil
- Assigned to Neha-Verma
- Open on Drupal.org →Core: 10.1.x + Environment: PHP 8.1 & MySQL 8last update
11 months ago Waiting for branch to pass - Issue was unassigned.
- Status changed to Needs review
11 months ago 8:03am 5 August 2023 - Open on Drupal.org →Core: 10.1.x + Environment: PHP 8.1 & MySQL 8last update
11 months ago Waiting for branch to pass - Assigned to Grevil
- Issue was unassigned.
- Status changed to Needs work
10 months ago 9:29am 4 September 2023 - 🇩🇪Germany Grevil
The patch contains unrelated changes to some of the .svg files. Furthermore, an MR would be preferable.
- Status changed to Needs review
10 months ago 10:55am 4 September 2023 - last update
10 months ago 88 pass - 🇮🇳India Shreya_98
@Grevil I have fixed the rest of the phpcs issues .Kindly review the patch file and i have attached the screenshot as well.
- Status changed to Needs work
5 months ago 9:50am 2 February 2024 - 🇵🇭Philippines clarkssquared
Hi
I applied MR !95 but it doesn't apply properly and there are many PHPCS issues that needs to be settled as you can see below
➜ cookies git:(1.2.x) curl https://git.drupalcode.org/project/cookies/-/merge_requests/95.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 15576 0 15576 0 0 24527 0 --:--:-- --:--:-- --:--:-- 24802 patching file 'config/schema/cookies.schema.yml' patching file cookies.links.menu.yml patching file cookies.module patching file 'modules/cookies_asset_injector/cookies_asset_injector.module' patching file 'modules/cookies_asset_injector/tests/src/FunctionalJavascript/TestCookiesAssetInjectorFunctionalJavascript.php' patching file 'modules/cookies_facebook_pixel/cookies_facebook_pixel.module' patching file 'modules/cookies_filter/src/Form/CookiesServiceFilterEntityForm.php' patching file 'modules/cookies_filter/src/Plugin/Filter/CookiesFilter.php' patching file 'modules/cookies_filter/src/Services/CookiesFilterElementTypesService.php' patching file 'modules/cookies_filter/tests/src/Functional/TestCookiesFilterFunctional.php' patching file 'modules/cookies_ga/cookies_ga.module' 1 out of 1 hunks failed--saving rejects to 'modules/cookies_ga/cookies_ga.module.rej' patching file 'modules/cookies_gtag/cookies_gtag.module' 1 out of 1 hunks failed--saving rejects to 'modules/cookies_gtag/cookies_gtag.module.rej' patching file 'modules/cookies_gtag/tests/src/Functional/CookiesGtagFunctionalTest.php' 1 out of 1 hunks failed--saving rejects to 'modules/cookies_gtag/tests/src/Functional/CookiesGtagFunctionalTest.php.rej' patching file 'modules/cookies_instagram/cookies_instagram.module' patching file 'modules/cookies_ivw/cookies_ivw.module' patching file 'modules/cookies_matomo/cookies_matomo.module' patching file 'modules/cookies_twitter_media/cookies_twitter_media.module' patching file 'modules/cookies_video/cookies_video.module' patching file 'src/Controller/CookiesDocsController.php' patching file 'src/Controller/ServiceConfigController.php' patching file 'src/Services/CookiesConfigService.php' ➜ cookies git:(1.2.x) ✗ .. ➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml cookies FILE: ...s/d9/d9-local/web/modules/contrib/cookies/modules/cookies_filter/README.md -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------- 25 | WARNING | Line exceeds 80 characters; contains 90 characters -------------------------------------------------------------------------------- FILE: ...es/modules/cookies_gtag/tests/src/Functional/CookiesGtagFunctionalTest.php -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------- 5 | WARNING | [x] Unused use statement -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...ontrib/cookies/modules/cookies_twitter_media/css/cookies_twitter_media.css -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------- 1 | WARNING | File appears to be minified and cannot be processed -------------------------------------------------------------------------------- FILE: ...d9-local/web/modules/contrib/cookies/modules/cookies_ga/cookies_ga.install -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 52 | ERROR | [x] Expected newline after closing brace -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...odules/contrib/cookies/modules/cookies_instagram/css/cookies_instagram.css -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------- 1 | WARNING | File appears to be minified and cannot be processed -------------------------------------------------------------------------------- FILE: ...es/contrib/cookies/modules/cookies_video/css/cookies_video_embed_field.css -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------- 1 | WARNING | File appears to be minified and cannot be processed -------------------------------------------------------------------------------- FILE: ...al/web/modules/contrib/cookies/modules/cookies_video/css/cookies_media.css -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------- 1 | WARNING | File appears to be minified and cannot be processed -------------------------------------------------------------------------------- FILE: ...odules/contrib/cookies/modules/cookies_recaptcha/css/cookies_recaptcha.css -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------- 1 | WARNING | File appears to be minified and cannot be processed -------------------------------------------------------------------------------- Time: 2.29 secs; Memory: 34MB ➜ contrib git:(master) ✗The MR is not mergable, so kindly fix it.
moving this to needs work
- 🇮🇳India Shreyas gowda
i found Zero errors but i can see few warnings
FILE: C:\wamp64\www\contribution\cookies\modules\cookies_filter\README.md
-------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------
25 | WARNING | Line exceeds 80 characters; contains 90 characters
-------------------------------------------------------------------------FILE: C:\wamp64\www\contribution\cookies\modules\cookies_instagram\css\cookies_instagram.css
--------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
--------------------------------------------------------------------------------------------FILE: C:\wamp64\www\contribution\cookies\modules\cookies_recaptcha\css\cookies_recaptcha.css
--------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
--------------------------------------------------------------------------------------------FILE: C:\wamp64\www\contribution\cookies\modules\cookies_twitter_media\css\cookies_twitter_media.css
----------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
----------------------------------------------------------------------------------------------------FILE: C:\wamp64\www\contribution\cookies\modules\cookies_video\css\cookies_media.css
------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
------------------------------------------------------------------------------------FILE: C:\wamp64\www\contribution\cookies\modules\cookies_video\css\cookies_video_embed_field.css
------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
------------------------------------------------------------------------------------------------ - Status changed to Closed: duplicate
4 months ago 12:56pm 21 February 2024 - 🇩🇪Germany Grevil
Already fixed as a part of 🐛 Aggregated JS knocked out Needs review .