Aggregated JS knocked out

Thanks @bgreco! Good finding! This makes sense to me, but I'd like to ensure it works using FunctionalJavascriptTests.

Could you please add a simple test, based on the existing, which fails with the current implementation and succeeds with the new one?
I'm also fine to test, if the script is present separately or something like that.

@Grevil: Could you perhaps test this manually by time?

I enabled JS aggregation for some tests, and that seems to be enough. The updated tests fail without this fix, and pass again with it.

Thanks @bgreco that looks great!

Wouldn't it perhaps make sense to test both: With and without aggregation enabled? So we should perhaps better have 2 tests calling a helper method?

    // Test that scripts are knocked out even when JS aggregation is enabled.
    $this->config('system.performance')->set('js.preprocess', TRUE)->save();

@Grevil what do you think?

Alright, I added some js aggregation tests on submodules, where I could easily just copy the pre-existing "testXXXJsCorrectlyKnocked" test and add a $this->config('system.performance')->set('js.preprocess', TRUE)->save(); in front of it.

Additionally, I threw in some automatic phpcs fixes for good measures (and to make the MR unreadable :P).

As these tests nor the phpcs fixes require a big review (since @Anybody and I already reviewed the core functionality), I'll just merge em, when the tests succeed.

LGTM!

All green! Let's merge this.

Ok one simple trait fix, while we are at it.

All green! Merging now for real.

Created a new release: https://www.drupal.org/project/cookies/releases/1.2.9 → .

Automatically closed - issue fixed for 2 weeks with no activity.